Chromium Code Reviews| Index: utils/testrunner/dart2js_task.dart |
| =================================================================== |
| --- utils/testrunner/dart2js_task.dart (revision 12649) |
| +++ utils/testrunner/dart2js_task.dart (working copy) |
| @@ -4,18 +4,18 @@ |
| /** A pipeline task to run the compiler. */ |
| class Dart2jsTask extends RunProcessTask { |
| - final String _jsFileTemplate; |
| + String _jsFileTemplate; |
|
Siggi Cherem (dart-lang)
2012/09/20 23:55:41
seems like this can still be final?
gram
2012/09/21 00:25:46
Done.
|
| - Dart2jsTask.checked(String dartFileTemplate, this._jsFileTemplate) { |
| - init(config.dart2jsPath, |
| - ['--enable_checked_mode', '--out=$_jsFileTemplate', dartFileTemplate], |
| - config.timeout); |
| - } |
| + Dart2jsTask.checked(String dartFileTemplate, jsFileTemplate) : |
| + super(config.dart2jsPath, |
| + ['--enable_checked_mode', '--out=$jsFileTemplate', dartFileTemplate], |
| + config.timeout), |
| + _jsFileTemplate = jsFileTemplate; |
| - Dart2jsTask(String dartFileTemplate, this._jsFileTemplate) { |
| - init(config.dart2jsPath, ['--out=$_jsFileTemplate', dartFileTemplate], |
| - config.timeout); |
| - } |
| + Dart2jsTask(String dartFileTemplate, jsFileTemplate) : |
| + super(config.dart2jsPath, ['--out=$jsFileTemplate', dartFileTemplate], |
| + config.timeout), |
| + _jsFileTemplate = jsFileTemplate; |
| void cleanup(Path testfile, List stdout, List stderr, |
| bool logging, bool keepFiles) { |