Added support for running an HTTP server during the test and being able to serve up static files. L…

Added support for running an HTTP server during the test and being able to serve up static files. Later this will be extended to being able to write tests on both ends of the connection, but this is a first step.
Committed: https://code.google.com/p/dart/source/detail?r=12674

[Siggi Cherem (dart-lang), 2012-09-20 23:55:41]

https://chromiumcodereview.appspot.com/10966020/diff/4001/utils/testrunner/cl...
File utils/testrunner/client_server_task.dart (right):

https://chromiumcodereview.appspot.com/10966020/diff/4001/utils/testrunner/cl...
utils/testrunner/client_server_task.dart:1: 
+copyright, + docs, + #library

https://chromiumcodereview.appspot.com/10966020/diff/4001/utils/testrunner/cl...
utils/testrunner/client_server_task.dart:14: 1000*timeout);
spaces around *

https://chromiumcodereview.appspot.com/10966020/diff/4001/utils/testrunner/da...
File utils/testrunner/dart2js_task.dart (right):

https://chromiumcodereview.appspot.com/10966020/diff/4001/utils/testrunner/da...
utils/testrunner/dart2js_task.dart:7: String _jsFileTemplate;
seems like this can still be final?

https://chromiumcodereview.appspot.com/10966020/diff/4001/utils/testrunner/ht...
File utils/testrunner/http_server_test_runner.dart (right):

https://chromiumcodereview.appspot.com/10966020/diff/4001/utils/testrunner/ht...
utils/testrunner/http_server_test_runner.dart:1: #library('server');
+cpyright, +docs

https://chromiumcodereview.appspot.com/10966020/diff/4001/utils/testrunner/ht...
utils/testrunner/http_server_test_runner.dart:7: static Map mime = null;
nit: rename to mime_types, possibly make it a static const or a top-level const
MIME_TYPES?

https://chromiumcodereview.appspot.com/10966020/diff/4001/utils/testrunner/ht...
utils/testrunner/http_server_test_runner.dart:16: 'json' : 'applicaton/json',
FYI - you could possibly read lots of mime types from /etc/mime.types

https://chromiumcodereview.appspot.com/10966020/diff/4001/utils/testrunner/ht...
utils/testrunner/http_server_test_runner.dart:45: (HttpRequest request,
HttpResponse response) {
I might prefer to move these as methods on this class. Speaking of which, can we
simply do HttpTestServer extends HttpServer?

[gram, 2012-09-21 00:25:46]

ptal

https://codereview.chromium.org/10966020/diff/4001/utils/testrunner/client_se...
File utils/testrunner/client_server_task.dart (right):

https://codereview.chromium.org/10966020/diff/4001/utils/testrunner/client_se...
utils/testrunner/client_server_task.dart:1: 
On 2012/09/20 23:55:41, sigmund wrote:
> +copyright, + docs, + #library

Done the first two; this is #sourced into testrunner.dart

https://codereview.chromium.org/10966020/diff/4001/utils/testrunner/client_se...
utils/testrunner/client_server_task.dart:14: 1000*timeout);
On 2012/09/20 23:55:41, sigmund wrote:
> spaces around *

Done.

https://codereview.chromium.org/10966020/diff/4001/utils/testrunner/dart2js_t...
File utils/testrunner/dart2js_task.dart (right):

https://codereview.chromium.org/10966020/diff/4001/utils/testrunner/dart2js_t...
utils/testrunner/dart2js_task.dart:7: String _jsFileTemplate;
On 2012/09/20 23:55:41, sigmund wrote:
> seems like this can still be final?

Done.

https://codereview.chromium.org/10966020/diff/4001/utils/testrunner/http_serv...
File utils/testrunner/http_server_test_runner.dart (right):

https://codereview.chromium.org/10966020/diff/4001/utils/testrunner/http_serv...
utils/testrunner/http_server_test_runner.dart:1: #library('server');
On 2012/09/20 23:55:41, sigmund wrote:
> +cpyright, +docs

Done.

https://codereview.chromium.org/10966020/diff/4001/utils/testrunner/http_serv...
utils/testrunner/http_server_test_runner.dart:7: static Map mime = null;
On 2012/09/20 23:55:41, sigmund wrote:
> nit: rename to mime_types, possibly make it a static const or a top-level
const
> MIME_TYPES?

That would be nice but for some reason Map literals are not considered constant
expressions and so I have to do this the way I am.

https://codereview.chromium.org/10966020/diff/4001/utils/testrunner/http_serv...
utils/testrunner/http_server_test_runner.dart:16: 'json' : 'applicaton/json',
On 2012/09/20 23:55:41, sigmund wrote:
> FYI - you could possibly read lots of mime types from /etc/mime.types

I could, but I think the list I have here is reasonable. I went through the
official list and picked out the ones we are likely to see (many of the others
are Windows only, obsolete or rare).

https://codereview.chromium.org/10966020/diff/4001/utils/testrunner/http_serv...
utils/testrunner/http_server_test_runner.dart:45: (HttpRequest request,
HttpResponse response) {
On 2012/09/20 23:55:41, sigmund wrote:
> I might prefer to move these as methods on this class. Speaking of which, can
we
> simply do HttpTestServer extends HttpServer?

I don't think so. It uses a factory constructor and trying to do an extends gave
an error.

[Siggi Cherem (dart-lang), 2012-09-21 00:37:53]

lgtm

https://codereview.chromium.org/10966020/diff/4001/utils/testrunner/client_se...
File utils/testrunner/client_server_task.dart (right):

https://codereview.chromium.org/10966020/diff/4001/utils/testrunner/client_se...
utils/testrunner/client_server_task.dart:1: 
On 2012/09/21 00:25:46, gram wrote:
> On 2012/09/20 23:55:41, sigmund wrote:
> > +copyright, + docs, + #library
> 
> Done the first two; this is #sourced into testrunner.dart

that will change soon, now that the new import syntax is supported (or partially
supported) we can start adding the "part" headings :)

https://codereview.chromium.org/10966020/diff/4001/utils/testrunner/http_serv...
File utils/testrunner/http_server_test_runner.dart (right):

https://codereview.chromium.org/10966020/diff/4001/utils/testrunner/http_serv...
utils/testrunner/http_server_test_runner.dart:7: static Map mime = null;
On 2012/09/21 00:25:46, gram wrote:
> On 2012/09/20 23:55:41, sigmund wrote:
> > nit: rename to mime_types, possibly make it a static const or a top-level
> const
> > MIME_TYPES?
> 
> That would be nice but for some reason Map literals are not considered
constant
> expressions and so I have to do this the way I am.
> 

there are considered if you prefix them with 'const'. For instance:

const Map<String, String> MIME_TYPES = const <String> {
 ...
}

https://codereview.chromium.org/10966020/diff/4001/utils/testrunner/http_serv...
utils/testrunner/http_server_test_runner.dart:45: (HttpRequest request,
HttpResponse response) {
On 2012/09/21 00:25:46, gram wrote:
> On 2012/09/20 23:55:41, sigmund wrote:
> > I might prefer to move these as methods on this class. Speaking of which,
can
> we
> > simply do HttpTestServer extends HttpServer?
> 
> I don't think so. It uses a factory constructor and trying to do an extends
gave
> an error.

seems small enough now, but if this grows, this might benefit from making this
into a method:
  server.defaultRequestHandler = handler;
}

void handler(request, response) {
  ...
}

[Søren Gjesse, 2012-09-21 07:08:09]

Drive by comments

https://chromiumcodereview.appspot.com/10966020/diff/7002/utils/testrunner/ht...
File utils/testrunner/http_server_test_runner.dart (right):

https://chromiumcodereview.appspot.com/10966020/diff/7002/utils/testrunner/ht...
utils/testrunner/http_server_test_runner.dart:62: }
These two lines are not needed. The default status code is HttpStatus.OK. If no
reason phrase is specified there is a default mapping from status code to reason
phrase.

https://chromiumcodereview.appspot.com/10966020/diff/7002/utils/testrunner/ht...
utils/testrunner/http_server_test_runner.dart:64: response.reasonPhrase = "OK";
Here you can just do

  f.openInputStream().pipe(response.outputStream);

instead of

  var content = f.readAsBytesSync();
  response.outputStream.write(content);
  response.outputStream.close();

pipe will close the output stream when done.

https://chromiumcodereview.appspot.com/10966020/diff/7002/utils/testrunner/ht...
utils/testrunner/http_server_test_runner.dart:69: response.statusCode =
HttpStatus.NOT_FOUND;
No need to set reason phrase.

https://chromiumcodereview.appspot.com/10966020/diff/7002/utils/testrunner/ht...
utils/testrunner/http_server_test_runner.dart:76: response.reasonPhrase = "$e";
Maybe add

response.writeString(s.toString());