Issue 10966010: [gtk] fix up appearance of website settings dropdown menus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10966010: [gtk] fix up appearance of website settings dropdown menus (Closed)

Created:
8 years, 3 months ago by Evan Stade

Modified:
8 years, 3 months ago

Reviewers:
markusheintz_

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[gtk] fix up appearance of website settings dropdown menus 1. work better under various system themes 2. make sure the button images always show BUG=15075 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157956

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -9 lines)			Patch
	M	chrome/browser/ui/gtk/website_settings/permission_selector.cc	View		1 chunk	+21 lines, -9 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

markusheintz_

http://codereview.chromium.org/10966010/diff/1/chrome/browser/ui/gtk/website_settings/permission_selector.cc File chrome/browser/ui/gtk/website_settings/permission_selector.cc (right): http://codereview.chromium.org/10966010/diff/1/chrome/browser/ui/gtk/website_settings/permission_selector.cc#newcode100 chrome/browser/ui/gtk/website_settings/permission_selector.cc:100: gtk_box_pack_start(GTK_BOX(button_hbox), arrow, FALSE, FALSE, 0); Does this work for ...

8 years, 3 months ago (2012-09-20 13:04:49 UTC) #1

Evan Stade

8 years, 3 months ago (2012-09-20 14:15:38 UTC) #2

LGTM

Expand Messages | Collapse Messages