Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1406)

Issue 1096553003: Revert 191807 "Supress script during parser adjusting DOM node l..." (Closed)

Created:
5 years, 8 months ago by amineer_google
Modified:
5 years, 8 months ago
Reviewers:
Hajime Morrita
CC:
blink-reviews
Visibility:
Public.

Description

Revert 191807 "Supress script during parser adjusting DOM node l..." Reverting on trunk to avoid crashes while a fix is landed BUG=471599 > Supress script during parser adjusting DOM node location > > This attack uses HTML parser's tree tweaking operation to trigger > a script execution. This CL supresses it. This should be acceptable > because: > > * It never happens with well-formed markup. > * It only happens to a node being a child of <script>, which is unusual. > > BUG=464552 > TEST=parser-adjust-parent-crash.html > R=haraken@chromium.org > > Review URL: https://codereview.chromium.org/1007523003 TBR=morrita@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -28 lines) Patch
D trunk/LayoutTests/fast/dom/parser-adjust-parent-crash.html View 1 chunk +0 lines, -20 lines 0 comments Download
D trunk/LayoutTests/fast/dom/parser-adjust-parent-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/core/html/parser/HTMLConstructionSite.cpp View 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
amineer_google
5 years, 8 months ago (2015-04-16 20:24:57 UTC) #1
amineer_google
5 years, 8 months ago (2015-04-16 20:25:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r193901.

Powered by Google App Engine
This is Rietveld 408576698