Do not use bundled gold when using GCC LTO.

Do not use bundled gold when using GCC LTO.

This is because GCC also uses the -B search path at link time to find
"as", and our bundled "as" can only target x86. See also the discussion at
https://codereview.chromium.org/1084133002/

(I also tried adding this condition around line 858, but this won't work
because of scoping issues ("clang" is not defined here)).

R=thakis@chromium.org,fdegans@chromium.org
BUG=469376
Committed: https://crrev.com/882ab8a296309793ae4cbd0fd6e2cc730ec050f3
Cr-Commit-Position: refs/heads/master@{#325545}

[Nico, 2015-04-16 19:17:12]

lgtm if fdegans thinks not using gold for gcc lto is ok

https://codereview.chromium.org/1096553002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1096553002/diff/1/build/common.gypi#newcode4543
build/common.gypi:4543: not (clang==0 and (use_lto==1 or use_lto_o2==1))', {
I think the python style guide prefers

  'abc'
  'def'

over

  'abc\
   def'

[pcc, 2015-04-16 19:45:15]

pcc@google.com changed reviewers:
+ pcc@google.com

[pcc, 2015-04-16 19:45:15]

https://codereview.chromium.org/1096553002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1096553002/diff/1/build/common.gypi#newcode4543
build/common.gypi:4543: not (clang==0 and (use_lto==1 or use_lto_o2==1))', {
On 2015/04/16 19:17:12, Nico wrote:
> I think the python style guide prefers
> 
>   'abc'
>   'def'
> 
> over
> 
>   'abc\
>    def'

Done.

[Fabrice (no longer in Chrome), 2015-04-16 21:40:16]

lgtm
This is about disabling bundled gold, not gold itself.

[pcc, 2015-04-16 21:49:24]

The CQ bit was checked by pcc@google.com

[pcc, 2015-04-16 21:49:24]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1096553002/#ps20001
(title: "Style")

[commit-bot: I haz the power, 2015-04-16 21:54:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1096553002/20001

[commit-bot: I haz the power, 2015-04-16 23:25:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-16 23:27:07]

Patchset 2 (id:??) landed as
https://crrev.com/882ab8a296309793ae4cbd0fd6e2cc730ec050f3
Cr-Commit-Position: refs/heads/master@{#325545}