Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 1096543002: [Sync] Make Directory's protected methods private where possible (Closed)

Created:
5 years, 8 months ago by maniscalco
Modified:
5 years, 8 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Make Directory's protected methods private where possible unrecoverable_error_set and one of the InitialSyncEndedForType overloads are only called by Directory so they can be made private. Remove name accessor as it's never called. BUG=475557 Committed: https://crrev.com/41082e577df1e51a8cea10e95f3d909edab5d89c Cr-Commit-Position: refs/heads/master@{#325529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M sync/syncable/directory.h View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
maniscalco
Pavel, would you please review this change?
5 years, 8 months ago (2015-04-16 19:38:40 UTC) #2
pavely
lgtm
5 years, 8 months ago (2015-04-16 20:11:45 UTC) #3
maniscalco
On 2015/04/16 20:11:45, pavely wrote: > lgtm Thanks for the quick review!
5 years, 8 months ago (2015-04-16 20:16:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096543002/1
5 years, 8 months ago (2015-04-16 21:01:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 22:47:12 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 22:48:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41082e577df1e51a8cea10e95f3d909edab5d89c
Cr-Commit-Position: refs/heads/master@{#325529}

Powered by Google App Engine
This is Rietveld 408576698