Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 109653013: MIPS: Improve registers saving for safepoints in deferred code. (Closed)

Created:
7 years ago by dusmil
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Improve registers saving for safepoints in deferred code. This reduces code size of initial snapshot by more than 25Kb. Registers are saved or restored via common stubs, instead of doing it through inlined push/pop instructions (one instruction per register) in generated deferred code. TEST= BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -9 lines) Patch
M src/code-stubs.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/mips/code-stubs-mips.h View 1 chunk +27 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +47 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 2 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dusmil
7 years ago (2013-12-20 17:52:25 UTC) #1
Paul Lind
LGTM. Jakob, Danno, could one of you PTAL for code-stubs.h
7 years ago (2013-12-20 18:00:43 UTC) #2
Jakob Kummerow
lgtm
7 years ago (2013-12-20 18:54:13 UTC) #3
Paul Lind
7 years ago (2013-12-20 19:45:31 UTC) #4
Committed as r18399.

Powered by Google App Engine
This is Rietveld 408576698