Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 109653010: Fix sporadic crash in the RequestInterruptTestWithNativeAccessor. (Closed)

Created:
7 years ago by Vyacheslav Egorov (Chromium)
Modified:
7 years ago
CC:
v8-dev
Visibility:
Public.

Description

Fix sporadic crash in the RequestInterruptTestWithNativeAccessor. The test was broken. V8 currently does not correctly lookup NativeDataProperty accessors attached to the PrototypeTemplate of FunctionTemplate (Issue 3066). As the result while(obj.shouldContinue) loop was immediately exiting and the test would terminate while RequestInterruptTestBase::InterruptThread would be still starting up. As the result later InterruptThread would try to access members of the test object which was destroyed. The test was fixed: - instead of attaching accessor to PrototypeTemplate we attach it to InstanceTemplate; - an assertion was added to verify that we completed the test successfully due to interruptor firing not due to sporadic loop termination due to some unrelated bug. R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M test/cctest/test-api.cc View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
7 years ago (2013-12-20 13:51:21 UTC) #1
Hannes Payer (out of office)
LGTM
7 years ago (2013-12-20 13:53:40 UTC) #2
Vyacheslav Egorov (Chromium)
7 years ago (2013-12-20 14:07:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18391.

Powered by Google App Engine
This is Rietveld 408576698