Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 10965042: Use new find in page resource on Windows too. (Closed)

Created:
8 years, 3 months ago by flackr
Modified:
8 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, dcheng, oshima+watch_chromium.org
Visibility:
Public.

Description

Use new find in page resource on Windows too. Screenshots are in bug. BUG=129757 TEST=None. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158560

Patch Set 1 #

Patch Set 2 : Add corrected assets and change chromeos separator color to match. #

Total comments: 1

Patch Set 3 : Use same separator color on windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-46 lines, -5 lines) Patch
M chrome/app/theme/default_100_percent/common/find_box_bg.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/find_box_bg_left.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/find_dialog_left.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/find_dialog_middle.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/find_dialog_right.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/find_dlg_left_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/find_dlg_middle_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/find_dlg_right_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/find_next.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/find_next_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/find_next_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/default_100_percent/common/find_next_pressed.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/find_prev.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/find_prev_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/find_prev_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/default_100_percent/common/find_prev_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_box_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_box_bg_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_dialog_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_dialog_middle.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_dialog_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_dlg_left_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_dlg_middle_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_dlg_right_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_next.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_next_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_next_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_next_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_prev.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_prev_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_prev_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/cros/find_prev_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/default_200_percent/common/find_box_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/common/find_box_bg_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/default_200_percent/common/find_dialog_left.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/default_200_percent/common/find_dialog_middle.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/default_200_percent/common/find_dialog_right.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/default_200_percent/common/find_dlg_left_bg.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/find_dlg_middle_bg.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/find_dlg_right_bg.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/find_next.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/find_next_disabled.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/find_next_hover.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/find_next_pressed.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/find_prev.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/find_prev_disabled.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/find_prev_hover.png View Binary file 0 comments Download
A + chrome/app/theme/default_200_percent/common/find_prev_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_box_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_box_bg_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_dialog_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_dialog_middle.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_dialog_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_dlg_left_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_dlg_middle_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_dlg_right_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_next.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_next_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_next_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_next_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_prev.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_prev_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_prev_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/cros/find_prev_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +16 lines, -36 lines 0 comments Download
A chrome/app/theme/touch_100_percent/common/find_box_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_100_percent/common/find_box_bg_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_100_percent/common/find_dialog_left.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_100_percent/common/find_dialog_middle.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_100_percent/common/find_dialog_right.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_100_percent/common/find_dlg_left_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_100_percent/common/find_dlg_middle_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/touch_100_percent/common/find_dlg_right_bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_100_percent/common/find_next.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_100_percent/common/find_next_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_100_percent/common/find_next_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_100_percent/common/find_next_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_100_percent/common/find_prev.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_100_percent/common/find_prev_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_100_percent/common/find_prev_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_100_percent/common/find_prev_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 4 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
flackr
Hi Scott, This adds the new Windows resources with a solid white find background. There ...
8 years, 2 months ago (2012-09-24 23:11:13 UTC) #1
sky
How come the border colors in win_default_100_find_in_page.png don't line up? Specifically the line around the ...
8 years, 2 months ago (2012-09-24 23:19:43 UTC) #2
flackr
On 2012/09/24 23:19:43, sky wrote: > How come the border colors in win_default_100_find_in_page.png don't line ...
8 years, 2 months ago (2012-09-24 23:58:02 UTC) #3
sky
8 years, 2 months ago (2012-09-25 00:19:21 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698