Set the config OMX_MirrorVertical to have same orientation as other video decoders

content/common/gpu/media/omx_video_decode_accelerator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/media/omx_video_decode_accelerator.h"
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/stl_util.h"
@@ skipping 172 matching lines @@
   OMX_U32 num_components = 1;
   std::string component(OMX_MAX_STRINGNAME_SIZE, '\0');
   char* component_as_array = string_as_array(&component);
   OMX_ERRORTYPE result = omx_get_components_of_role(
       role_name, &num_components,
       reinterpret_cast<OMX_U8**>(&component_as_array));
   RETURN_ON_OMX_FAILURE(result, "Unsupported role: " << role_name,
                         PLATFORM_FAILURE, false);
   RETURN_ON_FAILURE(num_components == 1, "No components for: " << role_name,
                     PLATFORM_FAILURE, false);
-  component_name_is_nvidia_h264ext_ = component == "OMX.Nvidia.h264ext.decode";
+  component_name_is_nvidia_h264ext_ = StartsWithASCII(component,
+                                   "OMX.Nvidia.h264ext.decode", true);

[Ami GONE FROM CHROMIUM, 2012/09/21 16:35:09]

indent is wrong

 
   // Get the handle to the component.
   result = omx_gethandle(
       &component_handle_,
       reinterpret_cast<OMX_STRING>(string_as_array(&component)),
       this, &omx_accelerator_callbacks);
   RETURN_ON_OMX_FAILURE(result,
                         "Failed to OMX_GetHandle on: " << component,
                         PLATFORM_FAILURE, false);
   client_state_ = OMX_StateLoaded;
@@ skipping 287 matching lines @@
     return;
   OMX_ERRORTYPE result = OMX_SendCommand(
       component_handle_, OMX_CommandStateSet, new_state, 0);
   RETURN_ON_OMX_FAILURE(result, "SendCommand(OMX_CommandStateSet) failed",
                         PLATFORM_FAILURE,);
 }
 
 void OmxVideoDecodeAccelerator::OnReachedIdleInInitializing() {
   DCHECK_EQ(client_state_, OMX_StateLoaded);
   client_state_ = OMX_StateIdle;
+  OMX_ERRORTYPE result = OMX_ErrorNone;

[Ami GONE FROM CHROMIUM, 2012/09/21 16:35:09]

unnecessary (and counter to chromium style; declare variables as late as
possible).

   // Query the resources with the component.
   if (component_name_is_nvidia_h264ext_) {
     OMX_INDEXTYPE extension_index;
-    OMX_ERRORTYPE result = OMX_GetExtensionIndex(
+    result = OMX_GetExtensionIndex(
         component_handle_,
         const_cast<char*>("OMX.Nvidia.index.config.checkresources"),
         &extension_index);
     RETURN_ON_OMX_FAILURE(result,
                           "Failed to get the extension",
                           PLATFORM_FAILURE,);
     OMX_VIDEO_PARAM_PROFILELEVELTYPE video_profile_level;
     InitParam(*this, &video_profile_level);
     DCHECK_EQ(codec_, H264);
     video_profile_level.eProfile = h264_profile_;
     result = OMX_SetConfig(component_handle_, extension_index,
                            &video_profile_level);
     RETURN_ON_OMX_FAILURE(result,
                           "Resource Allocation failed",
                           PLATFORM_FAILURE,);
+
+  // The OMX spec doesn't say whether (0,0) is bottom-left or top-left, but both

[Ami GONE FROM CHROMIUM, 2012/09/21 16:35:09]

indent is off

+  // OMX implementations used with this class far choose the same, and are the

[Ami GONE FROM CHROMIUM, 2012/09/21 16:35:09]

this isn't true anymore (which is why this code is inside the nvidia-specific
block).

+  // opposite of other APIs used for HW decode (DXVA, OS/X, VAAPI).  So we
+  // request a mirror here to avoid having to track Y-orientation throughout the
+  // stack (particularly unattractive because this is exposed to ppapi plugin
+  // authors and NaCl programs).
+    OMX_CONFIG_MIRRORTYPE mirror_config;
+    InitParam(*this, &mirror_config);
+    result = OMX_GetConfig( component_handle_,

[Ami GONE FROM CHROMIUM, 2012/09/21 16:35:09]

extra space

+                 OMX_IndexConfigCommonMirror, &mirror_config);

[Ami GONE FROM CHROMIUM, 2012/09/21 16:35:09]

indent is off

+    RETURN_ON_OMX_FAILURE(result, "Failed to get mirror", PLATFORM_FAILURE,);
+    mirror_config.eMirror = OMX_MirrorVertical;
+    result = OMX_SetConfig( component_handle_,

[Ami GONE FROM CHROMIUM, 2012/09/21 16:35:09]

extra space

+                 OMX_IndexConfigCommonMirror, &mirror_config);

[Ami GONE FROM CHROMIUM, 2012/09/21 16:35:09]

indent is off

+    RETURN_ON_OMX_FAILURE(result, "Failed to set mirror", PLATFORM_FAILURE,);
   }
   BeginTransitionToState(OMX_StateExecuting);
 }
 
 void OmxVideoDecodeAccelerator::OnReachedExecutingInInitializing() {
   DCHECK_EQ(client_state_, OMX_StateIdle);
   client_state_ = OMX_StateExecuting;
   current_state_change_ = NO_TRANSITION;
 
   // Request filling of our fake buffers to trigger decode processing.  In
@@ skipping 599 matching lines @@
 
 bool OmxVideoDecodeAccelerator::SendCommandToPort(
     OMX_COMMANDTYPE cmd, int port_index) {
   DCHECK_EQ(message_loop_, MessageLoop::current());
   OMX_ERRORTYPE result = OMX_SendCommand(component_handle_,
                                          cmd, port_index, 0);
   RETURN_ON_OMX_FAILURE(result, "SendCommand() failed" << cmd,
                         PLATFORM_FAILURE, false);
   return true;
 }