Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2260)

Unified Diff: Source/modules/background_sync/SyncRegistration.h

Issue 1096503002: [Background Sync] Converting Blink code to the MVP API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Unregister method requires the sync registration tag Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/background_sync/SyncManager.idl ('k') | Source/modules/background_sync/SyncRegistration.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/background_sync/SyncRegistration.h
diff --git a/Source/modules/background_sync/SyncRegistration.h b/Source/modules/background_sync/SyncRegistration.h
index 7c549cc12063fca5d50fb0864578c246b7e8c351..838b029ec408d96d3d76fbec78b4ae1d8e12fcb3 100644
--- a/Source/modules/background_sync/SyncRegistration.h
+++ b/Source/modules/background_sync/SyncRegistration.h
@@ -26,48 +26,19 @@ public:
virtual ~SyncRegistration();
- bool hasAllowOnBattery() const { return !m_allowOnBattery.isNull(); }
- bool allowOnBattery() const { return m_allowOnBattery.get(); }
- void setAllowOnBattery(bool value) { m_allowOnBattery = value; }
-
- bool hasId() const { return !m_id.isNull(); }
- String id() const { return m_id; }
- void setId(String value) { m_id = value; }
-
- bool hasIdleRequired() const { return !m_idleRequired.isNull(); }
- bool idleRequired() const { return m_idleRequired.get(); }
- void setIdleRequired(bool value) { m_idleRequired = value; }
-
- bool hasMaxDelay() const { return !m_maxDelay.isNull(); }
- unsigned long maxDelay() const { return m_maxDelay.get(); }
- void setMaxDelay(unsigned long value) { m_maxDelay = value; }
-
- bool hasMinDelay() const { return !m_minDelay.isNull(); }
- unsigned long minDelay() const { return m_minDelay.get(); }
- void setMinDelay(unsigned long value) { m_minDelay = value; }
-
- bool hasMinPeriod() const { return !m_minPeriod.isNull(); }
- unsigned long minPeriod() const { return m_minPeriod.get(); }
- void setMinPeriod(unsigned long value) { m_minPeriod = value; }
-
- bool hasMinRequiredNetwork() const { return !m_minRequiredNetwork.isNull(); }
- String minRequiredNetwork() const { return m_minRequiredNetwork; }
- void setMinRequiredNetwork(String value) { m_minRequiredNetwork = value; }
+ bool hasTag() const { return !m_tag.isNull(); }
+ String tag() const { return m_tag; }
+ void setTag(String value) { m_tag = value; }
ScriptPromise unregister(ScriptState*);
DECLARE_TRACE();
private:
- SyncRegistration(const SyncRegistrationOptions&, ServiceWorkerRegistration*);
+ SyncRegistration(int64_t id, const SyncRegistrationOptions&, ServiceWorkerRegistration*);
- Nullable<bool> m_allowOnBattery;
- String m_id;
- Nullable<bool> m_idleRequired;
- Nullable<unsigned long> m_maxDelay;
- Nullable<unsigned long> m_minDelay;
- Nullable<unsigned long> m_minPeriod;
- String m_minRequiredNetwork;
+ int64_t m_id;
+ String m_tag;
Member<ServiceWorkerRegistration> m_serviceWorkerRegistration;
};
« no previous file with comments | « Source/modules/background_sync/SyncManager.idl ('k') | Source/modules/background_sync/SyncRegistration.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698