Source/modules/background_sync/ServiceWorkerRegistrationSync.h - Issue 1096503002: [Background Sync] Converting Blink code to the MVP API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/background_sync/ServiceWorkerRegistrationSync.h

Issue 1096503002: [Background Sync] Converting Blink code to the MVP API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Unregister method requires the sync registration tag Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/background_sync/ServiceWorkerGlobalScopeSync.idl ('k') | Source/modules/background_sync/ServiceWorkerRegistrationSync.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/background_sync/ServiceWorkerRegistrationSync.h

diff --git a/Source/modules/background_sync/ServiceWorkerRegistrationSync.h b/Source/modules/background_sync/ServiceWorkerRegistrationSync.h

index 9ddc5043acdce82501c3cc7bb32a833b2452480e..14f1723583430fe3194fc212557f0502379b9f12 100644

--- a/Source/modules/background_sync/ServiceWorkerRegistrationSync.h

+++ b/Source/modules/background_sync/ServiceWorkerRegistrationSync.h

@@ -11,6 +11,7 @@

namespace blink {

class SyncManager;

+class PeriodicSyncManager;

class ServiceWorkerRegistration;

class ServiceWorkerRegistrationSync final : public GarbageCollectedFinalized<ServiceWorkerRegistrationSync>, public HeapSupplement<ServiceWorkerRegistration> {

@@ -20,8 +21,10 @@ public:

virtual ~ServiceWorkerRegistrationSync();

static ServiceWorkerRegistrationSync& from(ServiceWorkerRegistration&);

- static SyncManager* syncManager(ServiceWorkerRegistration&);

- SyncManager* syncManager();

+ static SyncManager* sync(ServiceWorkerRegistration&);

+ static PeriodicSyncManager* periodicSync(ServiceWorkerRegistration&);

+ SyncManager* sync();

+ PeriodicSyncManager* periodicSync();

DECLARE_VIRTUAL_TRACE();

@@ -31,6 +34,7 @@ private:

Member<ServiceWorkerRegistration> m_registration;

Member<SyncManager> m_syncManager;

+ Member<PeriodicSyncManager> m_periodicSyncManager;

};

} // namespace blink