Issue 10965021: Add wrapper method for enabling adb root.

Issue 10965021: Add wrapper method for enabling adb root. (Closed)

Created:
8 years, 3 months ago by shashi

Modified:
8 years, 3 months ago

Reviewers:
bulach, Isaac (away)

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add wrapper method for enabling adb root. Adds a wrapper to call EnableAdbRoot of adb_interface.py defined in android_testrunner. The called method enables adb root on the device by sending "adb root" command and waiting for device status. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157850

Patch Set 1 #

Patch Set 2 : add call to wait-for-device #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	build/android/pylib/android_commands.py	View	1	1 chunk	+14 lines, -0 lines	2 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/10965021/4001

8 years, 3 months ago (2012-09-20 21:42:01 UTC) #5

bulach

lgtm, thanks! https://chromiumcodereview.appspot.com/10965021/diff/4001/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://chromiumcodereview.appspot.com/10965021/diff/4001/build/android/pylib/android_commands.py#newcode222 build/android/pylib/android_commands.py:222: True: if output from executing adb reboot ...

8 years, 3 months ago (2012-09-21 10:36:45 UTC) #6

shashi

8 years, 3 months ago (2012-09-24 18:33:28 UTC) #7

https://chromiumcodereview.appspot.com/10965021/diff/4001/build/android/pylib...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/10965021/diff/4001/build/android/pylib...
build/android/pylib/android_commands.py:222: True: if output from executing adb
reboot was as expected.
Oops my bad, I have a CL to fix this.
On 2012/09/21 10:36:46, bulach wrote:
> nit: s/reboot/root/ :)
> also, I think 221-223 needs to be unindented by 1 space, i.e., Returns is
> aligned with the first quote """ from 219 (see 243-249 and other blocks
below..)

Expand Messages | Collapse Messages