Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: content/renderer/browser_plugin/browser_plugin_bindings.cc

Issue 10965017: Browser Plugin: Implement getProcessId (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed Nits Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin_bindings.cc
diff --git a/content/renderer/browser_plugin/browser_plugin_bindings.cc b/content/renderer/browser_plugin/browser_plugin_bindings.cc
index d8c75ad5bece01eaafc258f690db6a230278023b..d46bd525e9921715a394f071ee11a7f489667ae1 100644
--- a/content/renderer/browser_plugin/browser_plugin_bindings.cc
+++ b/content/renderer/browser_plugin/browser_plugin_bindings.cc
@@ -39,6 +39,7 @@ namespace content {
namespace {
const char kAddEventListener[] = "addEventListener";
+const char kGetProcessID[] = "getProcessId";
Charlie Reis 2012/09/21 00:24:06 Ah, the lowercase "d" in ID. How I hate that conv
Fady Samuel 2012/09/21 14:48:46 Done.
const char kRemoveEventListener[] = "removeEventListener";
const char kSrcAttribute[] = "src";
@@ -55,6 +56,10 @@ bool IdentifierIsRemoveEventListener(NPIdentifier identifier) {
return WebBindings::getStringIdentifier(kRemoveEventListener) == identifier;
}
+bool IdentifierIsGetProcessID(NPIdentifier identifier) {
+ return WebBindings::getStringIdentifier(kGetProcessID) == identifier;
+}
+
bool IdentifierIsSrcAttribute(NPIdentifier identifier) {
return WebBindings::getStringIdentifier(kSrcAttribute) == identifier;
}
@@ -112,6 +117,9 @@ bool BrowserPluginBindingsHasMethod(NPObject* np_obj, NPIdentifier name) {
if (IdentifierIsRemoveEventListener(name))
return true;
+ if (IdentifierIsGetProcessID(name))
+ return true;
+
return false;
}
@@ -154,6 +162,13 @@ bool BrowserPluginBindingsInvoke(NPObject* np_obj, NPIdentifier name,
return bindings->instance()->RemoveEventListener(event_name, function);
}
+ if (IdentifierIsGetProcessID(name) && !arg_count) {
+ int process_id = bindings->instance()->process_id();
+ result->type = NPVariantType_Int32;
+ result->value.intValue = process_id;
+ return true;
+ }
+
return false;
}

Powered by Google App Engine
This is Rietveld 408576698