Browser Plugin: Implement getProcessId

content/renderer/browser_plugin/browser_plugin_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/browser_plugin/browser_plugin_browsertest.h"
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "content/common/browser_plugin_messages.h"
@@ skipping 46 matching lines @@
   if (value.IsEmpty() || !value->IsString())
     return std::string();
 
   v8::Local<v8::String> v8_str = value->ToString();
   int length = v8_str->Utf8Length() + 1;
   scoped_array<char> str(new char[length]);
   v8_str->WriteUtf8(str.get(), length);
   return str.get();
 }
 
+int BrowserPluginTest::ExecuteScriptAndReturnInt(
+    const std::string& script) {
+  v8::Handle<v8::Value>  value = GetMainFrame()->executeScriptAndReturnValue(
+      WebKit::WebScriptSource(WebKit::WebString::fromUTF8(script.c_str())));
+  if (value.IsEmpty() || !value->IsInt32())
+    return 0;
+
+  return value->Int32Value();
+}
+
 // This test verifies that an initial resize occurs when we instantiate the
 // browser plugin. This test also verifies that the browser plugin is waiting
 // for a BrowserPluginMsg_UpdateRect in response. We issue an UpdateRect, and
 // we observe an UpdateRect_ACK, with the resize_pending_ reset, indiciating
 // that the BrowserPlugin is not waiting for any more UpdateRects to
 // satisfy its resize request.
 TEST_F(BrowserPluginTest, InitialResize) {
   LoadHTML(GetHTMLForBrowserPluginObject().c_str());
   // Verify that the information based on ResizeGuest is correct, and
   // use its TransportDIB::Id to paint.
@@ skipping 209 matching lines @@
   const char* kAddEventListener =
     "var url;"
     "function nav(u) {"
     "  url = u;"
     "}"
     "document.getElementById('browserplugin')."
     "    addEventListener('navigation', nav);";
   const char* kRemoveEventListener =
     "document.getElementById('browserplugin')."
     "    removeEventListener('navigation', nav);";
+  const char* kGetProcessID =
+      "document.getElementById('browserplugin')."

[lazyboy, 2012/09/20 19:47:04]

nit: next line fits in this line

[Fady Samuel, 2012/09/20 21:58:05]

Done.

+      "    getProcessId()";
   const char* kGoogleURL = "http://www.google.com/";
   const char* kGoogleNewsURL = "http://news.google.com/";
 
   LoadHTML(GetHTMLForBrowserPluginObject().c_str());
   ExecuteJavaScript(kAddEventListener);
   // Grab the BrowserPlugin's instance ID from its resize message.
   const IPC::Message* msg =
       browser_plugin_manager()->sink().GetFirstMessageMatching(
           BrowserPluginHostMsg_ResizeGuest::ID);
   ASSERT_TRUE(msg);
   PickleIterator iter = IPC::SyncMessage::GetDataIterator(msg);
   BrowserPluginHostMsg_ResizeGuest::SendParam  resize_params;
   ASSERT_TRUE(IPC::ReadParam(msg, &iter, &resize_params));
   int instance_id = resize_params.a;
 
   MockBrowserPlugin* browser_plugin =
       static_cast<MockBrowserPlugin*>(
           browser_plugin_manager()->GetBrowserPlugin(instance_id));
   ASSERT_TRUE(browser_plugin);
 
-  browser_plugin->DidNavigate(GURL(kGoogleURL));

[lazyboy, 2012/09/20 19:47:04]

ASSERT browser_plugin->getProcessId() == 0 if we haven't navigated to a page
yet?
I'm thinking if that's what we should expect though, or the behavior is just
undefined?

[Fady Samuel, 2012/09/20 21:58:05]

I believe 0 is a valid RenderProcessHost ID. I think it's fine to leave this
undefined or perhaps -1? I'll let Charlie take a look at htis CL and get his
input on this.

+  browser_plugin->DidNavigate(GURL(kGoogleURL), 1337);
   EXPECT_EQ(kGoogleURL, ExecuteScriptAndReturnString("url"));
+  EXPECT_EQ(1337, ExecuteScriptAndReturnInt(kGetProcessID));
 
   ExecuteJavaScript(kRemoveEventListener);
-  browser_plugin->DidNavigate(GURL(kGoogleNewsURL));
+  browser_plugin->DidNavigate(GURL(kGoogleNewsURL), 42);
   // The URL variable should not change because we've removed the event
   // listener.
   EXPECT_EQ(kGoogleURL, ExecuteScriptAndReturnString("url"));
+  EXPECT_EQ(42, ExecuteScriptAndReturnInt(kGetProcessID));
 }
 
 }  // namespace content