Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1096483004: Remove 2 duplicated SVG tests (Closed)

Created:
5 years, 8 months ago by baul.eun
Modified:
5 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews, kangil_
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove 2 duplicated SVG tests This patch removes the following W3C-SVG-1.1 tests in favor of their duplicated versions in W3C-SVG-1.1-SE. The associated expectation files have been updated as well. 1. LayoutTests/svg/W3C-SVG-1.1/coords-units-03-b.svg 2. LayoutTests/svg/W3C-SVG-1.1/filters-felem-01-b.svg BUG=477550 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194556

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Remove expected files, Change description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -723 lines) Patch
D LayoutTests/platform/android/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/W3C-SVG-1.1/coords-units-03-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt View 1 1 chunk +0 lines, -88 lines 0 comments Download
D LayoutTests/platform/linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt View 1 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/platform/mac/svg/W3C-SVG-1.1/coords-units-03-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt View 1 1 chunk +0 lines, -88 lines 0 comments Download
D LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt View 1 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/W3C-SVG-1.1/coords-units-03-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt View 1 1 chunk +0 lines, -88 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt View 1 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/platform/win/svg/W3C-SVG-1.1/coords-units-03-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt View 1 1 chunk +0 lines, -88 lines 0 comments Download
D LayoutTests/platform/win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt View 1 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/svg/W3C-SVG-1.1/coords-units-03-b.svg View 1 chunk +0 lines, -163 lines 0 comments Download
D LayoutTests/svg/W3C-SVG-1.1/filters-felem-01-b.svg View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
baul.eun
PTAL!! :)
5 years, 8 months ago (2015-04-17 06:50:45 UTC) #2
pdr.
Overall this looks pretty good. I went through these and confirmed these tests are fine ...
5 years, 8 months ago (2015-04-18 03:27:46 UTC) #3
baul.eun
PTAL :)
5 years, 7 months ago (2015-04-26 05:03:03 UTC) #4
baul.eun
Hi pdr :) PTAL !! :)
5 years, 7 months ago (2015-04-26 05:14:49 UTC) #5
pdr.
lgtm
5 years, 7 months ago (2015-04-27 22:28:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096483004/60001
5 years, 7 months ago (2015-04-27 22:28:33 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 23:51:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194556

Powered by Google App Engine
This is Rietveld 408576698