Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Issue 1096463005: Fix pdfium standalone to compile with VS 2015. (Closed)

Created:
5 years, 8 months ago by brucedawson
Modified:
5 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix pdfium standalone to compile with VS 2015. This change disables several warnings that fire frequently in pdfium and are not practical to fix at this time. R=tsepez@chromium.org BUG=440500 Committed: https://pdfium.googlesource.com/pdfium/+/0e2e6ce29f2a5dc60798194860daa4b5c04b93cf

Patch Set 1 #

Patch Set 2 : Tweak comments and reinstate WarnAsError. #

Patch Set 3 : Explain /Zc:sizedDealloc- switch. #

Patch Set 4 : Remove /Zc:sizedDealloc- because v8 has a different fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/standalone.gypi View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brucedawson
5 years, 8 months ago (2015-04-16 20:10:40 UTC) #1
brucedawson
With this change pdfium builds cleanly (no warnings) with VS 2015. I checked that it ...
5 years, 8 months ago (2015-04-16 20:11:11 UTC) #2
Tom Sepez
Rubberstamp LGTM.
5 years, 8 months ago (2015-04-16 20:35:48 UTC) #3
brucedawson
5 years, 8 months ago (2015-04-16 20:45:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
0e2e6ce29f2a5dc60798194860daa4b5c04b93cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698