Don't attempt to delete and readd a duplicate hwnd in the SetFrameWindow notification in the metro …

win8/metro_driver/chrome_app_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "win8/metro_driver/stdafx.h"
 #include "win8/metro_driver/chrome_app_view.h"
 
 #include <algorithm>
 #include <windows.applicationModel.datatransfer.h>
 #include <windows.foundation.h>
@@ skipping 200 matching lines @@
   DVLOG(1) << __FUNCTION__ << ", hwnd=" << LONG_PTR(hwnd);
 
   HWND current_top_frame =
       !globals.host_windows.empty() ? globals.host_windows.front().first : NULL;
   if (hwnd != current_top_frame && IsWindow(current_top_frame)) {
     DVLOG(1) << "Hiding current top window, hwnd="
                << LONG_PTR(current_top_frame);
     ::ShowWindow(current_top_frame, SW_HIDE);
   }
 
-  // If chrome opens a url in a foreground tab, it may call SetFrameWindow
-  // again. Ensure that we don't have dups.
-  globals.host_windows.remove_if([hwnd](std::pair<HWND, bool>& item) {
+  std::list<std::pair<HWND, bool> >::iterator index =
+      std::find_if(globals.host_windows.begin(), globals.host_windows.end(),
+              [hwnd](std::pair<HWND, bool>& item) {
     return (item.first == hwnd);
   });
 
-  globals.host_windows.push_front(std::make_pair(hwnd, false));
-
-  AdjustFrameWindowStyleForMetro(hwnd);
+  if (index == globals.host_windows.end()) {
+    globals.host_windows.push_front(std::make_pair(hwnd, false));
+    AdjustFrameWindowStyleForMetro(hwnd);
+  }
 }
 
 void CloseFrameWindowInternal(HWND hwnd) {
   DVLOG(1) << __FUNCTION__ << ", hwnd=" << LONG_PTR(hwnd);
 
   globals.host_windows.remove_if([hwnd](std::pair<HWND, bool>& item) {
     return (item.first == hwnd);
   });
 
   if (globals.host_windows.size() > 0) {
@@ skipping 939 matching lines @@
   CheckHR(core_app.As(&app_exit));
   globals.app_exit = app_exit.Detach();
 }
 
 IFACEMETHODIMP
 ChromeAppViewFactory::CreateView(winapp::Core::IFrameworkView** view) {
   globals.view = mswr::Make<ChromeAppView>().Detach();
   *view = globals.view;
   return (*view) ? S_OK :  E_OUTOFMEMORY;
 }