Issue 10964010: Revert 157723 - Revert 157713 - Make database failures in LeveldbValueStore more descriptive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10964010: Revert 157723 - Revert 157713 - Make database failures in LeveldbValueStore more descriptive. (Closed)

Created:
8 years, 3 months ago by not at google - send to devlin

Modified:
8 years, 3 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 157723 - Revert 157713 - Make database failures in LeveldbValueStore more descriptive. Reason: memory leak. Reason: actually, I just need to update a suppression. Note that I initially intentionally didn't do this so that extensions didn't get any unnecessary information. However, it will help with bug reports. BUG=149888 Review URL: https://chromiumcodereview.appspot.com/10928227 TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/10956008 TBR=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157724

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -85 lines)			Patch
	M	chrome/browser/value_store/leveldb_value_store.h	View		1 chunk	+10 lines, -12 lines	0 comments	Download
	M	chrome/browser/value_store/leveldb_value_store.cc	View		13 chunks	+118 lines, -73 lines	0 comments	Download

Total messages: 1 (0 generated)