Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: lib/html/scripts/systemhtml.py

Issue 10963057: Emit static IDL members. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/html/scripts/systembase.py ('k') | tests/html/html.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/scripts/systemhtml.py
diff --git a/lib/html/scripts/systemhtml.py b/lib/html/scripts/systemhtml.py
index e1e4d4259d7c59fbaa8c8db79536ddfaf747a0b4..c53a284fb13d7d9bf4cbe5d49b93296d00d467a2 100644
--- a/lib/html/scripts/systemhtml.py
+++ b/lib/html/scripts/systemhtml.py
@@ -662,16 +662,20 @@ class HtmlDartInterfaceGenerator(BaseGenerator):
DOMINTERFACE=info.overloads[0].doc_js_interface_name,
DOMNAME=info.name)
- self._members_emitter.Emit('\n'
- ' $TYPE $NAME($PARAMS);\n',
- TYPE=self._DartType(info.type_name),
- NAME=html_name,
- PARAMS=info.ParametersInterfaceDeclaration(self._DartType))
+ if info.IsStatic():
+ # FIXME: provide a type.
+ self._members_emitter.Emit('\n'
+ ' static final $NAME = $IMPL_CLASS_NAME.$NAME;\n',
+ IMPL_CLASS_NAME=self._backend.ImplementationClassName(),
+ NAME=html_name)
+ else:
+ self._members_emitter.Emit('\n'
+ ' $TYPE $NAME($PARAMS);\n',
+ TYPE=self._DartType(info.type_name),
+ NAME=html_name,
+ PARAMS=info.ParametersInterfaceDeclaration(self._DartType))
self._backend.AddOperation(info, html_name)
- def AddStaticOperation(self, info):
- self.AddOperation(info, True)
-
def AddSecondaryOperation(self, interface, info):
self._backend.SecondaryContext(interface)
self.AddOperation(info, True)
@@ -1009,10 +1013,6 @@ class HtmlDart2JSClassGenerator(Dart2JSInterfaceGenerator):
if self._HasCustomImplementation(info.name):
return
- # FIXME: support static operations.
- if info.IsStatic():
- return
-
# Any conversions needed?
if any(self._OperationRequiresConversions(op) for op in info.overloads):
self._AddOperationWithConversions(info, html_name)
« no previous file with comments | « lib/html/scripts/systembase.py ('k') | tests/html/html.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698