Issue 10963038: drive: Set a custom User-Agent header for Drive operations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10963038: drive: Set a custom User-Agent header for Drive operations (Closed)

Created:
8 years, 3 months ago by satorux1

Modified:
8 years, 3 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Set a custom User-Agent header for Drive operations This allows the Drive backend to distinguish our client and process statistics nicely. This patch introduces two known issues (crbug.com/151605), which will be fixed at a later time. This patch is made small so we can merge it to M23 branch safely. BUG=150028 TEST=open chrome:net-internals; open Files.app; open Drive; click on a .txt file to fetch it. go to chrome:net-internals. Find the c Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158103

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -0 lines)			Patch
	M	chrome/browser/google_apis/DEPS	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/google_apis/operations_base.cc	View	1	4 chunks	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

lgtm https://codereview.chromium.org/10963038/diff/1/chrome/browser/google_apis/operations_base.cc File chrome/browser/google_apis/operations_base.cc (right): https://codereview.chromium.org/10963038/diff/1/chrome/browser/google_apis/operations_base.cc#newcode83 chrome/browser/google_apis/operations_base.cc:83: const std::string library = "chrome-cc/none"; nit: use const ...

8 years, 3 months ago (2012-09-21 21:11:12 UTC) #2

satorux1

8 years, 3 months ago (2012-09-21 22:41:22 UTC) #3

http://codereview.chromium.org/10963038/diff/1/chrome/browser/google_apis/ope...
File chrome/browser/google_apis/operations_base.cc (right):

http://codereview.chromium.org/10963038/diff/1/chrome/browser/google_apis/ope...
chrome/browser/google_apis/operations_base.cc:83: const std::string library =
"chrome-cc/none";
On 2012/09/21 21:11:12, Daniel Erat wrote:
> nit: use const char kLibraryName[] here?

Done.

Expand Messages | Collapse Messages