Fix /analyze warning and update code URL.

Fix /analyze warning and update code URL.

Committed: https://crrev.com/08f8097c710309712d5100af194aae04213b60e3
Cr-Commit-Position: refs/heads/master@{#330569}

[Georges Khalil, 2015-05-19 15:37:07]

georgesak@chromium.org changed reviewers:
+ dsinclair@chromium.org, georgesak@chromium.org

[Georges Khalil, 2015-05-19 15:37:07]

LGTM.

Dan, we need your owner's LGTM as well, thanks :)

[dsinclair, 2015-05-19 15:39:37]

lgtm w/ nit

https://codereview.chromium.org/1096303003/diff/1/base/trace_event/trace_even...
File base/trace_event/trace_event_etw_export_win.cc (right):

https://codereview.chromium.org/1096303003/diff/1/base/trace_event/trace_even...
base/trace_event/trace_event_etw_export_win.cc:54: *RegHandle = 0;
Does chromium still use 0 or is nullptr acceptable now?

[Georges Khalil, 2015-05-19 15:48:12]

On 2015/05/19 15:39:37, dsinclair wrote:
> lgtm w/ nit
> 
>
https://codereview.chromium.org/1096303003/diff/1/base/trace_event/trace_even...
> File base/trace_event/trace_event_etw_export_win.cc (right):
> 
>
https://codereview.chromium.org/1096303003/diff/1/base/trace_event/trace_even...
> base/trace_event/trace_event_etw_export_win.cc:54: *RegHandle = 0;
> Does chromium still use 0 or is nullptr acceptable now?

(*RegHandle) is actually not a pointer but an unsigned long long. RegHandle is
of type PREGHANDLE and is defined as typedef ULONGLONG * PREGHANDLE (Gotta love
Windows naming!).

PS: to answer your question, nullptr is perfectly acceptable in Chrome (I think
it's even suggested now).

[brucedawson, 2015-05-19 17:28:40]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2015-05-19 17:30:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1096303003/1

[commit-bot: I haz the power, 2015-05-19 18:36:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-19 18:37:03]

Patchset 1 (id:??) landed as
https://crrev.com/08f8097c710309712d5100af194aae04213b60e3
Cr-Commit-Position: refs/heads/master@{#330569}