Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Side by Side Diff: runtime/bin/process.h

Issue 10963024: Use native fields for process pid and fix bug that allowed killing (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review commetns. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/bin/process.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef BIN_PROCESS_H_ 5 #ifndef BIN_PROCESS_H_
6 #define BIN_PROCESS_H_ 6 #define BIN_PROCESS_H_
7 7
8 #include "bin/builtin.h" 8 #include "bin/builtin.h"
9 #include "platform/globals.h" 9 #include "platform/globals.h"
10 10
(...skipping 18 matching lines...) Expand all
29 29
30 // Kill a process with a given pid. 30 // Kill a process with a given pid.
31 static bool Kill(intptr_t id, int signal); 31 static bool Kill(intptr_t id, int signal);
32 32
33 // Terminate the exit code handler thread. Does not return before 33 // Terminate the exit code handler thread. Does not return before
34 // the thread has terminated. 34 // the thread has terminated.
35 static void TerminateExitCodeHandler(); 35 static void TerminateExitCodeHandler();
36 36
37 static intptr_t CurrentProcessId(); 37 static intptr_t CurrentProcessId();
38 38
39 static Dart_Handle GetProcessIdNativeField(Dart_Handle process,
40 intptr_t* pid);
41 static Dart_Handle SetProcessIdNativeField(Dart_Handle process,
42 intptr_t pid);
43
39 DISALLOW_ALLOCATION(); 44 DISALLOW_ALLOCATION();
40 DISALLOW_IMPLICIT_CONSTRUCTORS(Process); 45 DISALLOW_IMPLICIT_CONSTRUCTORS(Process);
41 }; 46 };
42 47
43 #endif // BIN_PROCESS_H_ 48 #endif // BIN_PROCESS_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/bin/process.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698