Issue 10963005: Fix missing slot recodring during clearing of CallICs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10963005: Fix missing slot recodring during clearing of CallICs. (Closed)

Created:
8 years, 3 months ago by Michael Starzinger

Modified:
8 years, 3 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix missing slot recodring during clearing of CallICs. This fixes a rare corner case that was caused by missing recording of relocation slots when the uninitialized CallIC stub happenes to land on an evacuation candidate and the IC is cleared via the shared function. R=ulan@chromium.org BUG=chromium:144230 TEST=cctest/test-heap/Regression144230 Committed: https://code.google.com/p/v8/source/detail?r=12563

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -2 lines)			Patch
	M	src/ic-inl.h	View		2 chunks	+10 lines, -2 lines	0 comments	Download
	M	test/cctest/test-heap.cc	View		2 chunks	+61 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Awesome, LGTM! Thanks for fixing it :)

Expand Messages | Collapse Messages