Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5506)

Unified Diff: chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc

Issue 1096293003: Move screenlock_bridge to components/proximity_auth (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add proximity auth client and the chrome glue. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc
diff --git a/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc b/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc
index 75aa1b298b488bdcbe4554b236d1a3ea3a3f99f7..9643c806fac513bf62da78c45abd4087699c4607 100644
--- a/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc
+++ b/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc
@@ -13,8 +13,9 @@
#include "base/test/histogram_tester.h"
#include "chrome/browser/signin/easy_unlock_metrics.h"
#include "chrome/browser/signin/easy_unlock_service.h"
-#include "chrome/browser/signin/screenlock_bridge.h"
+#include "chrome/browser/signin/easy_unlock_util.h"
#include "chrome/grit/generated_resources.h"
+#include "components/proximity_auth/screenlock_bridge.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"
@@ -207,7 +208,7 @@ class EasyUnlockScreenlockStateHandlerTest : public testing::Test {
void SetUp() override {
// Create and inject fake lock handler to the screenlock bridge.
lock_handler_.reset(new TestLockHandler(user_email_));
- ScreenlockBridge* screenlock_bridge = ScreenlockBridge::Get();
+ ScreenlockBridge* screenlock_bridge = GetScreenlockBridgeInstance();
screenlock_bridge->SetLockHandler(lock_handler_.get());
// Create the screenlock state handler object that will be tested.
@@ -218,7 +219,7 @@ class EasyUnlockScreenlockStateHandlerTest : public testing::Test {
}
void TearDown() override {
- ScreenlockBridge::Get()->SetLockHandler(NULL);
+ GetScreenlockBridgeInstance()->SetLockHandler(NULL);
lock_handler_.reset();
state_handler_.reset();
}
@@ -432,10 +433,10 @@ TEST_F(EasyUnlockScreenlockStateHandlerTest, StatePreservedWhenScreenUnlocks) {
lock_handler_->GetAuthType(user_email_));
ASSERT_TRUE(lock_handler_->HasCustomIcon());
- ScreenlockBridge::Get()->SetLockHandler(NULL);
+ GetScreenlockBridgeInstance()->SetLockHandler(NULL);
lock_handler_.reset(new TestLockHandler(user_email_));
EXPECT_EQ(0u, lock_handler_->GetAndResetShowIconCount());
- ScreenlockBridge::Get()->SetLockHandler(lock_handler_.get());
+ GetScreenlockBridgeInstance()->SetLockHandler(lock_handler_.get());
EXPECT_EQ(1u, lock_handler_->GetAndResetShowIconCount());
EXPECT_EQ(ScreenlockBridge::LockHandler::USER_CLICK,
@@ -452,14 +453,14 @@ TEST_F(EasyUnlockScreenlockStateHandlerTest, StateChangeWhileScreenUnlocked) {
lock_handler_->GetAuthType(user_email_));
ASSERT_TRUE(lock_handler_->HasCustomIcon());
- ScreenlockBridge::Get()->SetLockHandler(NULL);
+ GetScreenlockBridgeInstance()->SetLockHandler(NULL);
lock_handler_.reset(new TestLockHandler(user_email_));
EXPECT_EQ(0u, lock_handler_->GetAndResetShowIconCount());
state_handler_->ChangeState(
EasyUnlockScreenlockStateHandler::STATE_BLUETOOTH_CONNECTING);
- ScreenlockBridge::Get()->SetLockHandler(lock_handler_.get());
+ GetScreenlockBridgeInstance()->SetLockHandler(lock_handler_.get());
EXPECT_EQ(1u, lock_handler_->GetAndResetShowIconCount());
EXPECT_EQ(ScreenlockBridge::LockHandler::OFFLINE_PASSWORD,
@@ -492,9 +493,9 @@ TEST_F(EasyUnlockScreenlockStateHandlerTest,
<< "State: " << states[i];
}
- ScreenlockBridge::Get()->SetLockHandler(NULL);
+ GetScreenlockBridgeInstance()->SetLockHandler(NULL);
lock_handler_.reset(new TestLockHandler(user_email_));
- ScreenlockBridge::Get()->SetLockHandler(lock_handler_.get());
+ GetScreenlockBridgeInstance()->SetLockHandler(lock_handler_.get());
for (size_t i = 0; i < states.size(); ++i) {
state_handler_->ChangeState(states[i]);
@@ -655,10 +656,10 @@ TEST_F(EasyUnlockScreenlockStateHandlerTest,
state_handler_->SetHardlockState(
EasyUnlockScreenlockStateHandler::NO_HARDLOCK);
- ScreenlockBridge::Get()->SetLockHandler(NULL);
+ GetScreenlockBridgeInstance()->SetLockHandler(NULL);
lock_handler_.reset(new TestLockHandler(user_email_));
EXPECT_EQ(0u, lock_handler_->GetAndResetShowIconCount());
- ScreenlockBridge::Get()->SetLockHandler(lock_handler_.get());
+ GetScreenlockBridgeInstance()->SetLockHandler(lock_handler_.get());
state_handler_->ChangeState(
EasyUnlockScreenlockStateHandler::STATE_NO_PHONE);
@@ -666,10 +667,10 @@ TEST_F(EasyUnlockScreenlockStateHandlerTest,
EXPECT_EQ(2u, lock_handler_->GetAndResetShowIconCount());
EXPECT_TRUE(lock_handler_->HasCustomIcon());
- ScreenlockBridge::Get()->SetLockHandler(NULL);
+ GetScreenlockBridgeInstance()->SetLockHandler(NULL);
lock_handler_.reset(new TestLockHandler(user_email_));
EXPECT_EQ(0u, lock_handler_->GetAndResetShowIconCount());
- ScreenlockBridge::Get()->SetLockHandler(lock_handler_.get());
+ GetScreenlockBridgeInstance()->SetLockHandler(lock_handler_.get());
EXPECT_EQ(1u, lock_handler_->GetAndResetShowIconCount());
EXPECT_TRUE(lock_handler_->HasCustomIcon());
@@ -693,10 +694,10 @@ TEST_F(EasyUnlockScreenlockStateHandlerTest, HardlockStatePersistsOverUnlocks) {
EasyUnlockScreenlockStateHandler::USER_HARDLOCK);
EXPECT_EQ(2u, lock_handler_->GetAndResetShowIconCount());
- ScreenlockBridge::Get()->SetLockHandler(NULL);
+ GetScreenlockBridgeInstance()->SetLockHandler(NULL);
lock_handler_.reset(new TestLockHandler(user_email_));
EXPECT_EQ(0u, lock_handler_->GetAndResetShowIconCount());
- ScreenlockBridge::Get()->SetLockHandler(lock_handler_.get());
+ GetScreenlockBridgeInstance()->SetLockHandler(lock_handler_.get());
EXPECT_EQ(1u, lock_handler_->GetAndResetShowIconCount());
EXPECT_EQ(ScreenlockBridge::LockHandler::OFFLINE_PASSWORD,

Powered by Google App Engine
This is Rietveld 408576698