Move screenlock_bridge to components/proximity_auth

chrome/browser/chromeos/login/screens/user_selection_screen.cc

Index: chrome/browser/chromeos/login/screens/user_selection_screen.cc
diff --git a/chrome/browser/chromeos/login/screens/user_selection_screen.cc b/chrome/browser/chromeos/login/screens/user_selection_screen.cc
index 2156e875ba8628f148baace53f9a2db02cb3f8a4..47af52839b06c95201b3d2fd4540ca2a4177749a 100644
--- a/chrome/browser/chromeos/login/screens/user_selection_screen.cc
+++ b/chrome/browser/chromeos/login/screens/user_selection_screen.cc
@@ -17,10 +17,14 @@
 #include "chrome/browser/chromeos/login/users/multi_profile_user_controller.h"
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_window.h"
 #include "chrome/browser/signin/easy_unlock_service.h"
-#include "chrome/browser/signin/screenlock_bridge.h"
+#include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/ui/webui/chromeos/login/l10n_util.h"
 #include "chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h"
+#include "components/signin/content/screenlock_bridge.h"
+#include "components/signin/core/browser/signin_manager_base.h"
 #include "components/user_manager/user_id.h"
 #include "components/user_manager/user_manager.h"
 #include "components/user_manager/user_type.h"
@@ -488,6 +492,17 @@ void UserSelectionScreen::EnableInput() {
     ScreenLocker::default_screen_locker()->EnableInput();
 }
 
+void UserSelectionScreen::Lock(content::BrowserContext* browser_context) {
+  profiles::LockProfile(Profile::FromBrowserContext(browser_context));
+}
+
+void UserSelectionScreen::Unlock(content::BrowserContext* browser_context) {
+  Profile* profile = Profile::FromBrowserContext(browser_context);
+  SigninManagerBase* signin_manager =
+      SigninManagerFactory::GetForProfile(profile);

[Ilya Sherman, 2015/04/21 23:02:39]

This is not exactly equivalent to the previous implementation.  Could you please
preserve the previous implementation?

[msarda, 2015/04/22 16:42:42]

Done.

+  Unlock(signin_manager->GetAuthenticatedUsername());
+}

[Ilya Sherman, 2015/04/21 23:02:39]

Rather than duplicating the implementations of these methods here and in
user_manager_screen_handler.cc, I'd prefer to share the implementation.  One
reasonable approach is to use a client interface, as we do in other components.

[msarda, 2015/04/22 16:42:42]

I considered using a client interface, however IMHO the API would be extremely
weird as the ScreenlockBridge is a singleton and it only created and accessed
via ScreenlockBridge::Get. I do not see how / when I could set the client of the
SceeenLockBridge.

I think the natural place for this is the LockHandler (this is actually the
client interface for the ScreenlockBridge).

[Ilya Sherman, 2015/04/23 07:09:48]

The component setup code could call a method to set the client for the
ScreenlockBridge very early on, before any other calls to Get() are made.  The
ScreenlockBridge could guarantee this by not null-checking the client, which
would mean that if the setup code did not execute early enough, we'd see a null
pointer dereference, which is easy to track down.
Actually, the LockHandler is only set when the screen is locked.  So, it really
doesn't make very much sense for the LockHandler to have a Lock() method -- the
ScreenlockBridge won't have a lock handler set if we're calling Lock().



All that said, if you really don't like the idea of using a client interface,
and can demonstrate that I'm wrong about the Lock() method, then please at least
create a single ChromeLockHandler class that these two classes can both derive
from, rather than duplicating the code.

+
 void UserSelectionScreen::Unlock(const std::string& user_email) {
   DCHECK_EQ(GetScreenType(), LOCK_SCREEN);
   ScreenLocker::Hide();