Devtools:[CustomFormatter] Allow object tags in headers

Devtools:[CustomFormatter] Allow object tags in headers

Also extend interface with optional config parameter

BUG=478374, 476465
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194327

[sergeyv, 2015-04-21 12:44:51]

sergeyv@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2015-04-21 17:22:55]

Please add a test for recursive references.

[sergeyv, 2015-04-22 12:20:30]

On 2015/04/21 17:22:55, pfeldman wrote:
> Please add a test for recursive references.

Done

[sergeyv, 2015-04-22 16:39:05]

please take a look

[pfeldman, 2015-04-23 09:50:52]

lgtm

https://codereview.chromium.org/1096283003/diff/20001/Source/devtools/front_e...
File Source/devtools/front_end/components/CustomPreviewSection.js (right):

https://codereview.chromium.org/1096283003/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/components/CustomPreviewSection.js:25:
WebInspector.console.error("Broken formatter: header should be tag. Text node
aren't allowed as header!");
Header should be an element node.

[sergeyv, 2015-04-23 10:09:10]

https://codereview.chromium.org/1096283003/diff/20001/Source/devtools/front_e...
File Source/devtools/front_end/components/CustomPreviewSection.js (right):

https://codereview.chromium.org/1096283003/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/components/CustomPreviewSection.js:25:
WebInspector.console.error("Broken formatter: header should be tag. Text node
aren't allowed as header!");
On 2015/04/23 09:50:52, pfeldman wrote:
> Header should be an element node.

Done.

[sergeyv, 2015-04-23 10:09:13]

The CQ bit was checked by sergeyv@chromium.org

[sergeyv, 2015-04-23 10:09:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1096283003/#ps40001
(title: "Fix error message")

[commit-bot: I haz the power, 2015-04-23 10:09:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1096283003/40001

[commit-bot: I haz the power, 2015-04-23 14:36:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-23 14:36:37]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/53161)

[sergeyv, 2015-04-23 16:39:14]

The CQ bit was checked by sergeyv@chromium.org

[sergeyv, 2015-04-23 16:39:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1096283003/#ps60001
(title: "fix test with dcheck_always_on")

[commit-bot: I haz the power, 2015-04-23 16:39:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1096283003/60001

[commit-bot: I haz the power, 2015-04-23 22:00:35]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194327