Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1096263005: Remove special theming for CardUnmaskPrompt since it's now automatic (Closed)

Created:
5 years, 8 months ago by Evan Stade
Modified:
5 years, 8 months ago
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove special theming for CardUnmaskPrompt since it's now automatic for all alert dialogs. BUG=463576 Committed: https://crrev.com/d9456757bec482f2b27cf75ef7fa2109af0500a6 Cr-Commit-Position: refs/heads/master@{#326869}

Patch Set 1 #

Patch Set 2 : remove color #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -20 lines) Patch
M chrome/android/java/res/values-v17/styles.xml View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Evan Stade
5 years, 8 months ago (2015-04-24 02:03:47 UTC) #2
newt (away)
lgtm
5 years, 8 months ago (2015-04-24 03:12:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096263005/20001
5 years, 8 months ago (2015-04-24 20:14:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 20:41:22 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d9456757bec482f2b27cf75ef7fa2109af0500a6 Cr-Commit-Position: refs/heads/master@{#326869}
5 years, 8 months ago (2015-04-24 20:42:18 UTC) #7
Evan Stade
5 years, 8 months ago (2015-04-24 22:11:09 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1097263003/ by estade@chromium.org.

The reason for reverting is: automatic alert dialog styling was reverted, so
revert this as well for now..

Powered by Google App Engine
This is Rietveld 408576698