Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1096243004: Perform a sizet->int checked_cast in WebURLLoaderImpl::OnReceiveWebBlobData. (Closed)

Created:
5 years, 8 months ago by msw
Modified:
5 years, 8 months ago
Reviewers:
Elliot Glaysher, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Perform a sizet->int checked_cast in WebURLLoaderImpl::OnReceiveWebBlobData. Fixes an error on my Windows build: d:\src\chrome-git\src\components\html_viewer\web_url_loader_impl.cc(254) : error C2220: warning treated as error - no 'object' file generated d:\src\chrome-git\src\components\html_viewer\web_url_loader_impl.cc(254) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data BUG=NONE TEST=Windows html_viewer build succeeds. R=erg@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/7142727598a3ce06b0e636004dfb1646e677b65d Cr-Commit-Position: refs/heads/master@{#326898}

Patch Set 1 #

Patch Set 2 : Fix comment typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M components/html_viewer/web_url_loader_impl.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
msw
Hey Elliot, please take a look; thanks!
5 years, 8 months ago (2015-04-24 21:27:48 UTC) #1
Elliot Glaysher
lgtm
5 years, 8 months ago (2015-04-24 21:33:14 UTC) #2
msw
TBR'ing Scott for OWNERS; I also fixed a typo.
5 years, 8 months ago (2015-04-24 21:39:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096243004/20001
5 years, 8 months ago (2015-04-24 21:41:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 22:05:51 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 22:06:46 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7142727598a3ce06b0e636004dfb1646e677b65d
Cr-Commit-Position: refs/heads/master@{#326898}

Powered by Google App Engine
This is Rietveld 408576698