Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1096243003: Migrate error messages, part 5 (array.js and i18n.js). (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Migrate error messages, part 5 (array.js and i18n.js). R=mvstanton@chromium.org Committed: https://crrev.com/cadf96da9049330f4701147f042ebc7038cd6dbf Cr-Commit-Position: refs/heads/master@{#28040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -133 lines) Patch
M src/array.js View 4 chunks +5 lines, -10 lines 0 comments Download
M src/date.js View 1 chunk +0 lines, -5 lines 0 comments Download
M src/harmony-array.js View 1 chunk +1 line, -2 lines 0 comments Download
M src/i18n.js View 34 chunks +45 lines, -59 lines 0 comments Download
M src/macros.py View 2 chunks +2 lines, -2 lines 0 comments Download
M src/messages.h View 5 chunks +35 lines, -1 line 0 comments Download
M src/messages.js View 5 chunks +6 lines, -5 lines 0 comments Download
M src/string.js View 1 chunk +1 line, -2 lines 0 comments Download
M src/uri.js View 5 chunks +21 lines, -41 lines 0 comments Download
M src/v8natives.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/messages.js View 5 chunks +53 lines, -2 lines 0 comments Download
M tools/js2c.py View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 8 months ago (2015-04-23 08:17:58 UTC) #1
mvstanton
lgtm
5 years, 8 months ago (2015-04-24 09:18:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096243003/1
5 years, 8 months ago (2015-04-24 09:43:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 10:22:06 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 10:22:19 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cadf96da9049330f4701147f042ebc7038cd6dbf
Cr-Commit-Position: refs/heads/master@{#28040}

Powered by Google App Engine
This is Rietveld 408576698