Cleanup: Remove deprecated version of views::CreateDialogFrameView().

Cleanup: Remove deprecated version of views::CreateDialogFrameView().

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250308

[Mike Wittman, 2013-12-11 15:09:18]

Thanks for cleaning this up!

https://codereview.chromium.org/109623005/diff/1/chrome/browser/ui/views/cons...
File chrome/browser/ui/views/constrained_window_views.cc (right):

https://codereview.chromium.org/109623005/diff/1/chrome/browser/ui/views/cons...
chrome/browser/ui/views/constrained_window_views.cc:142:
views::NonClientFrameView* CreateConstrainedStyleNonClientFrameView(
This function can be removed entirely, as well as all of the
DialogDelegate::CreateDialogFrameView overrides that call it.

https://codereview.chromium.org/109623005/diff/1/ui/views/window/dialog_deleg...
File ui/views/window/dialog_delegate.cc (left):

https://codereview.chromium.org/109623005/diff/1/ui/views/window/dialog_deleg...
ui/views/window/dialog_delegate.cc:185: #if defined(USE_AURA)
Remove this also.

[msw, 2013-12-11 17:47:13]

https://codereview.chromium.org/109623005/diff/1/ui/views/window/dialog_deleg...
File ui/views/window/dialog_delegate.cc (left):

https://codereview.chromium.org/109623005/diff/1/ui/views/window/dialog_deleg...
ui/views/window/dialog_delegate.cc:185: #if defined(USE_AURA)
On 2013/12/11 15:09:18, Mike Wittman wrote:
> Remove this also.

We are trying to avoid breaking non-Aura Win until Aura reaches stable.

https://codereview.chromium.org/109623005/diff/1/ui/views/window/dialog_deleg...
File ui/views/window/dialog_delegate.h (left):

https://codereview.chromium.org/109623005/diff/1/ui/views/window/dialog_deleg...
ui/views/window/dialog_delegate.h:96: // reasonable-looking opaque border for
the dialog. Note that this does not
Hmm, I was considering using this to create top-level dialogs in Windows Aura
with the Windows Classic theme (no Aero DWM Glass), as the pictures in comments
#3 and #4 at http://crbug.com/323278#c3 (I had to revert to the old style for
the hung renderer dialog). But since I'm not sure I'll end up using this, I
guess you can remove it for now.

[Mike Wittman, 2014-02-05 17:34:04]

ping

I believe these changes can proceed now since we've started removing non-Aura
Windows code: http://crbug.com/330735

[msw, 2014-02-05 18:51:57]

On 2014/02/05 17:34:04, Mike Wittman wrote:
> ping
> 
> I believe these changes can proceed now since we've started removing non-Aura
> Windows code: http://crbug.com/330735

Yup, you can go ahead and address Mike's earlier comments.
(let me know if you'd like me to pickup this work)

[Lei Zhang, 2014-02-07 00:03:41]

https://codereview.chromium.org/109623005/diff/1/chrome/browser/ui/views/cons...
File chrome/browser/ui/views/constrained_window_views.cc (right):

https://codereview.chromium.org/109623005/diff/1/chrome/browser/ui/views/cons...
chrome/browser/ui/views/constrained_window_views.cc:142:
views::NonClientFrameView* CreateConstrainedStyleNonClientFrameView(
On 2013/12/11 15:09:18, Mike Wittman wrote:
> This function can be removed entirely, as well as all of the
> DialogDelegate::CreateDialogFrameView overrides that call it.

Done.

[Mike Wittman, 2014-02-07 15:02:43]

lgtm

https://codereview.chromium.org/109623005/diff/30001/chrome/browser/ui/views/...
File chrome/browser/ui/views/login_prompt_views.cc (left):

https://codereview.chromium.org/109623005/diff/30001/chrome/browser/ui/views/...
chrome/browser/ui/views/login_prompt_views.cc:11: #include
"chrome/browser/ui/views/constrained_window_views.h"
Remove this?

https://codereview.chromium.org/109623005/diff/30001/ui/views/window/dialog_d...
File ui/views/window/dialog_delegate.cc (left):

https://codereview.chromium.org/109623005/diff/30001/ui/views/window/dialog_d...
ui/views/window/dialog_delegate.cc:18: #include "ui/views/corewm/shadow_types.h"
include order

[Lei Zhang, 2014-02-07 22:55:21]

https://codereview.chromium.org/109623005/diff/30001/chrome/browser/ui/views/...
File chrome/browser/ui/views/login_prompt_views.cc (left):

https://codereview.chromium.org/109623005/diff/30001/chrome/browser/ui/views/...
chrome/browser/ui/views/login_prompt_views.cc:11: #include
"chrome/browser/ui/views/constrained_window_views.h"
On 2014/02/07 15:02:44, Mike Wittman wrote:
> Remove this?

Done.

https://codereview.chromium.org/109623005/diff/30001/ui/views/window/dialog_d...
File ui/views/window/dialog_delegate.cc (left):

https://codereview.chromium.org/109623005/diff/30001/ui/views/window/dialog_d...
ui/views/window/dialog_delegate.cc:18: #include "ui/views/corewm/shadow_types.h"
On 2014/02/07 15:02:44, Mike Wittman wrote:
> include order

Done.

[Lei Zhang, 2014-02-07 22:55:25]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-02-07 22:56:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/109623005/190001

[commit-bot: I haz the power, 2014-02-07 23:22:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-07 23:22:03]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Lei Zhang, 2014-02-08 00:46:44]

msw: ui/ OWNERS please.

[msw, 2014-02-10 19:21:14]

LGTM with nits.

https://codereview.chromium.org/109623005/diff/190001/chrome/browser/ui/views...
File chrome/browser/ui/views/download/download_danger_prompt_views.cc (right):

https://codereview.chromium.org/109623005/diff/190001/chrome/browser/ui/views...
chrome/browser/ui/views/download/download_danger_prompt_views.cc:77:
content::WebContents* web_contents_;
nit: this member (and its corresponding ctor param) can also be removed.

https://codereview.chromium.org/109623005/diff/190001/chrome/browser/ui/views...
File chrome/browser/ui/views/pdf_password_dialog.cc (right):

https://codereview.chromium.org/109623005/diff/190001/chrome/browser/ui/views...
chrome/browser/ui/views/pdf_password_dialog.cc:50: content::BrowserContext*
browser_context_;
nit: this member can also be removed.

https://codereview.chromium.org/109623005/diff/190001/chrome/browser/ui/views...
File chrome/browser/ui/views/tab_modal_confirm_dialog_views.h (right):

https://codereview.chromium.org/109623005/diff/190001/chrome/browser/ui/views...
chrome/browser/ui/views/tab_modal_confirm_dialog_views.h:71:
content::BrowserContext* browser_context_;
nit: this member and its corresponding forward decl can also be removed.

[Lei Zhang, 2014-02-10 23:21:42]

https://codereview.chromium.org/109623005/diff/190001/chrome/browser/ui/views...
File chrome/browser/ui/views/download/download_danger_prompt_views.cc (right):

https://codereview.chromium.org/109623005/diff/190001/chrome/browser/ui/views...
chrome/browser/ui/views/download/download_danger_prompt_views.cc:77:
content::WebContents* web_contents_;
On 2014/02/10 19:21:15, msw wrote:
> nit: this member (and its corresponding ctor param) can also be removed.

Done.

https://codereview.chromium.org/109623005/diff/190001/chrome/browser/ui/views...
File chrome/browser/ui/views/pdf_password_dialog.cc (right):

https://codereview.chromium.org/109623005/diff/190001/chrome/browser/ui/views...
chrome/browser/ui/views/pdf_password_dialog.cc:50: content::BrowserContext*
browser_context_;
On 2014/02/10 19:21:15, msw wrote:
> nit: this member can also be removed.

Done.

https://codereview.chromium.org/109623005/diff/190001/chrome/browser/ui/views...
File chrome/browser/ui/views/tab_modal_confirm_dialog_views.h (right):

https://codereview.chromium.org/109623005/diff/190001/chrome/browser/ui/views...
chrome/browser/ui/views/tab_modal_confirm_dialog_views.h:71:
content::BrowserContext* browser_context_;
On 2014/02/10 19:21:15, msw wrote:
> nit: this member and its corresponding forward decl can also be removed.

Done.

[Lei Zhang, 2014-02-10 23:21:48]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-02-10 23:23:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/109623005/480001

[Lei Zhang, 2014-02-10 23:24:00]

The CQ bit was unchecked by thestig@chromium.org

[Lei Zhang, 2014-02-10 23:26:35]

Hmm, I probably looked in the wrong OWNERS file. +sky for ui/

[sky, 2014-02-11 00:36:23]

ui LGTM

[Lei Zhang, 2014-02-11 00:59:46]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-02-11 01:00:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/109623005/480001

[commit-bot: I haz the power, 2014-02-11 03:35:52]

Change committed as 250308