[cc] Color evicted vs. invalidated checkerboard tiles differently

[cc] Color evicted vs. invalidated checkerboard tiles differently

If --show-debug-layer-borders are on, tint checkerboards differently.

* Light red = texture backing for tile was evicted or never painted
* Light blue = we have a texture backing, but it's been invalidated

BUG=150610
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158148

[enne (OOO), 2012-09-21 21:17:13]

I thought about adding Yet Another Layer Border Color, but we already have fruit
salad.  I feel like this is much more clear.

Also, yes, it doesn't handle the case where you're on a platform (Android) that
doesn't use checkerboards.  I'm not sure what to do there.

[jamesr, 2012-09-21 22:28:08]

lgtm

https://codereview.chromium.org/10962042/diff/1/cc/CCRendererGL.cpp
File cc/CCRendererGL.cpp (right):

https://codereview.chromium.org/10962042/diff/1/cc/CCRendererGL.cpp#newcode288
cc/CCRendererGL.cpp:288: GLC(context(),
context()->uniform4f(program->fragmentShader().colorLocation(),
SkColorGetR(color) / 255.0, SkColorGetG(color) / 255.0, SkColorGetB(color), 1));
why are you dividing red and green by 255.0 but leaving blue alone?

https://codereview.chromium.org/10962042/diff/1/cc/CCTiledLayerImpl.cpp
File cc/CCTiledLayerImpl.cpp (right):

https://codereview.chromium.org/10962042/diff/1/cc/CCTiledLayerImpl.cpp#newco...
cc/CCTiledLayerImpl.cpp:162: SkColor defaultColor = SkColorSetARGB(255,
defaultCheckerboardColorRed, defaultCheckerboardColorGreen,
defaultCheckerboardColorBlue);
SkColorSetRGB() is shorter if you don't have transparency

https://codereview.chromium.org/10962042/diff/1/cc/CCTiledLayerImpl.cpp#newco...
cc/CCTiledLayerImpl.cpp:168: checkerColor = !tile ? evictedColor :
invalidatedColor;
Hmm, I find ternaries on inverted bools a bit harder to follow - how would you
feel about "tile ? invalidatedColor : evictedColor;"

[commit-bot: I haz the power, 2012-09-21 22:38:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/10962042/5001

[commit-bot: I haz the power, 2012-09-22 02:12:51]

Change committed as 158148