Issue 10962033: Blacklist VMWare software renderer on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10962033: Blacklist VMWare software renderer on Linux. (Closed)

Created:
8 years, 3 months ago by Zhenyao Mo

Modified:
8 years, 3 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Blacklist VMWare software renderer on Linux. BUG=145531 TEST=content_unittests R=kbr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158054

Patch Set 1 #

Total comments: 4

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	content/browser/gpu/software_rendering_list.json	View		2 chunks	+16 lines, -1 line	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

LGTM with one issue fixed. https://codereview.chromium.org/10962033/diff/1/content/browser/gpu/software_rendering_list.json File content/browser/gpu/software_rendering_list.json (right): https://codereview.chromium.org/10962033/diff/1/content/browser/gpu/software_rendering_list.json#newcode71 content/browser/gpu/software_rendering_list.json:71: "version": "3.1", Just curious, ...

8 years, 3 months ago (2012-09-21 19:08:02 UTC) #2

Zhenyao Mo

8 years, 3 months ago (2012-09-21 19:57:59 UTC) #3

https://codereview.chromium.org/10962033/diff/1/content/browser/gpu/software_...
File content/browser/gpu/software_rendering_list.json (right):

https://codereview.chromium.org/10962033/diff/1/content/browser/gpu/software_...
content/browser/gpu/software_rendering_list.json:71: "version": "3.1",
On 2012/09/21 19:08:02, kbr wrote:
> Just curious, any particular reason to update the major version?

This is to reflect now the file is in content/.

https://codereview.chromium.org/10962033/diff/1/content/browser/gpu/software_...
content/browser/gpu/software_rendering_list.json:701: "value": "VMWare"
On 2012/09/21 19:08:02, kbr wrote:
> The capitalization doesn't match that in the bug report. Should be "VMware",
> here and in the description.

Thanks for catching this.  Updated.

Expand Messages | Collapse Messages