net/socket/transport_client_socket_pool_test_util.h - Issue 1096203006: Collect all ConnectionAttempts from both sockets in TransportConnectJob.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/transport_client_socket_pool_test_util.h

Issue 1096203006: Collect all ConnectionAttempts from both sockets in TransportConnectJob. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@domrel_serverip1

Patch Set: Add a couple comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/socket/transport_client_socket_pool.cc ('K') | « net/socket/transport_client_socket_pool.cc ('k') | net/socket/transport_client_socket_pool_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/socket/transport_client_socket_pool_test_util.h

diff --git a/net/socket/transport_client_socket_pool_test_util.h b/net/socket/transport_client_socket_pool_test_util.h

index 7b0daa3d2fc9790a2e948af87dd1df9c254f9238..6e38af6661361b49368b5371b622beba9753a9c7 100644

--- a/net/socket/transport_client_socket_pool_test_util.h

+++ b/net/socket/transport_client_socket_pool_test_util.h

@@ -62,6 +62,9 @@ class MockTransportClientSocketFactory : public ClientSocketFactory {

MOCK_DELAYED_FAILING_CLIENT_SOCKET,

// A stalled socket that never connects at all.

MOCK_STALLED_CLIENT_SOCKET,

+ // A stalled socket that never connects at all, but returns a failing

+ // ConnectionAttempt in |GetConnectionAttempts|.

+ MOCK_STALLED_FAILING_CLIENT_SOCKET,

// A socket that can be triggered to connect explicitly, asynchronously.

MOCK_TRIGGERABLE_CLIENT_SOCKET,

};