Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5020)

Unified Diff: net/socket/client_socket_handle.h

Issue 1096203006: Collect all ConnectionAttempts from both sockets in TransportConnectJob. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@domrel_serverip1
Patch Set: Add a couple comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/client_socket_handle.h
diff --git a/net/socket/client_socket_handle.h b/net/socket/client_socket_handle.h
index 58cf4ca6709b8d72c9fb86193142cd25d8409fc2..2f8bed2080b8e6dcacf67028a695284aecc273b1 100644
--- a/net/socket/client_socket_handle.h
+++ b/net/socket/client_socket_handle.h
@@ -156,6 +156,9 @@ class NET_EXPORT ClientSocketHandle {
ClientSocketHandle* release_pending_http_proxy_connection() {
return pending_http_proxy_connection_.release();
}
+ // If the connection failed, returns the connection attempts made. (If it
+ // succeeded, they will be returned through the socket instead; see
+ // |StreamSocket::GetConnectionAttempts|.)
Randy Smith (Not in Mondays) 2015/05/14 19:42:05 Is this relevant for this level of API? From my n
Deprecated (see juliatuttle) 2015/05/14 20:02:35 It's a storage location that is fairly intimately
const ConnectionAttempts& connection_attempts() {
return connection_attempts_;
}

Powered by Google App Engine
This is Rietveld 408576698