chrome/browser/devtools/device/usb/android_usb_socket.cc - Issue 1096203006: Collect all ConnectionAttempts from both sockets in TransportConnectJob.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/usb/android_usb_socket.cc

Issue 1096203006: Collect all ConnectionAttempts from both sockets in TransportConnectJob. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@domrel_serverip1

Patch Set: Make requested changes; rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/usb/android_usb_socket.h ('k') | chrome/browser/extensions/api/socket/tls_socket_unittest.cc » ('j') | net/socket/stream_socket.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/usb/android_usb_socket.cc

diff --git a/chrome/browser/devtools/device/usb/android_usb_socket.cc b/chrome/browser/devtools/device/usb/android_usb_socket.cc

index fde3230457f3e43bcf7a43ff1f5bfce4d614ee7a..1ea19faad31f96283a58159047e7c05c4095d2ee 100644

--- a/chrome/browser/devtools/device/usb/android_usb_socket.cc

+++ b/chrome/browser/devtools/device/usb/android_usb_socket.cc

@@ -234,6 +234,10 @@ bool AndroidUsbSocket::GetSSLInfo(net::SSLInfo* ssl_info) {

return false;

}

+void AndroidUsbSocket::GetConnectionAttempts(ConnectionAttempts* out) const {

+ out->clear();

void AndroidUsbSocket::RespondToReader(bool disconnect) {

if (read_callback_.is_null() || (read_buffer_.empty() && !disconnect))

return;