net/http/http_stream_factory_impl_job.h - Issue 1096203006: Collect all ConnectionAttempts from both sockets in TransportConnectJob.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_job.h

Issue 1096203006: Collect all ConnectionAttempts from both sockets in TransportConnectJob. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@domrel_serverip1

Patch Set: Document why Do*ConnectComplete don't delete other socket Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_stream_factory_impl_job.h

diff --git a/net/http/http_stream_factory_impl_job.h b/net/http/http_stream_factory_impl_job.h

index a5793d16a466b60e958dd3d572a514e75dcfb6a4..5eefef02db14277afb7b27723aa8a87885e13f4b 100644

--- a/net/http/http_stream_factory_impl_job.h

+++ b/net/http/http_stream_factory_impl_job.h

@@ -280,7 +280,7 @@ class HttpStreamFactoryImpl::Job {

ClientSocketPoolManager::SocketGroupType GetSocketGroup() const;

- void MaybeCopyConnectionAttemptsFromClientSocketHandleToRequest();

+ void MaybeCopyConnectionAttempts();

// Record histograms of latency until Connect() completes.

static void LogHttpConnectedMetrics(const ClientSocketHandle& handle);

« no previous file with comments | « no previous file | net/http/http_stream_factory_impl_job.cc » ('j') | net/http/http_stream_factory_impl_job.cc » ('J')