Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1096203003: rlz: Silence spam from lock RecursiveCrossProcessLock (Closed)

Created:
5 years, 8 months ago by spang
Modified:
5 years, 8 months ago
Reviewers:
Nico, Ivan Korotkov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

rlz: Silence spam from RecursiveCrossProcessLock Change perror() to VPLOG() to avoid spamming the console with these errors (they reliably occur on the login screen). BUG=463306 TEST=build, boot, & login to pixel Committed: https://crrev.com/ce89b915d34a6bbe645da530b61bc3461e49f70f Cr-Commit-Position: refs/heads/master@{#326621}

Patch Set 1 #

Patch Set 2 : oops.. add .value() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M rlz/lib/recursive_cross_process_lock_posix.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
spang
5 years, 8 months ago (2015-04-20 23:06:41 UTC) #2
Nico
Maybe we shouldn't call this code while on the login screen then? +ivankr who did ...
5 years, 8 months ago (2015-04-22 17:05:49 UTC) #4
Ivan Korotkov
On 2015/04/22 17:05:49, Nico (OOO sick) wrote: > Maybe we shouldn't call this code while ...
5 years, 8 months ago (2015-04-22 17:59:11 UTC) #5
spang
On 2015/04/22 17:59:11, Ivan Korotkov wrote: > On 2015/04/22 17:05:49, Nico (OOO sick) wrote: > ...
5 years, 8 months ago (2015-04-22 19:12:15 UTC) #6
spang
On 2015/04/22 17:05:49, Nico (OOO sick) wrote: > Maybe we shouldn't call this code while ...
5 years, 8 months ago (2015-04-23 17:47:32 UTC) #7
Nico
On 2015/04/23 17:47:32, spang wrote: > On 2015/04/22 17:05:49, Nico (OOO sick) wrote: > > ...
5 years, 8 months ago (2015-04-23 17:52:40 UTC) #8
spang
On 2015/04/23 17:52:40, Nico (OOO sick) wrote: > On 2015/04/23 17:47:32, spang wrote: > > ...
5 years, 8 months ago (2015-04-23 19:01:30 UTC) #9
Nico
lgtm Probably not worth the time arguing about this :-)
5 years, 8 months ago (2015-04-23 19:04:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096203003/1
5 years, 8 months ago (2015-04-23 19:06:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096203003/20001
5 years, 8 months ago (2015-04-23 19:34:52 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 20:11:35 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 20:12:30 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ce89b915d34a6bbe645da530b61bc3461e49f70f
Cr-Commit-Position: refs/heads/master@{#326621}

Powered by Google App Engine
This is Rietveld 408576698