Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 10962024: Reapply "Let Layout::GetSupportedScaleFactorFromScale() return only supported ScaleFactor." (Closed)

Created:
8 years, 3 months ago by Xianzhu
Modified:
8 years, 3 months ago
Reviewers:
pkotwicz, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Reapply "Let Layout::GetSupportedScaleFactorFromScale() return only supported ScaleFactor." Original Review URL: https://chromiumcodereview.appspot.com/10946019 Reverted in: https://codereview.chromium.org/10959035 Removed LayoutTest.GetScaleFactorFromScaleNoneSupported() in the original patch because GetSupportedScaleFactors() will initialize the supported scale factors to default after test::SetSupportedScaleFactors(std::vector<ScaleFactor>()). And it's also not a real scenario. BUG=148841 TBR=sky,pkotwicz Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157935

Patch Set 1 : Original patch which was reverted in https://codereview.chromium.org/10959035 #

Patch Set 2 : Remove LayoutTest.GetScaleFactorFromScaleNoneSupported #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -6 lines) Patch
M ui/base/layout.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/layout.cc View 1 chunk +8 lines, -5 lines 0 comments Download
A ui/base/layout_unittest.cc View 1 1 chunk +67 lines, -0 lines 0 comments Download
M ui/ui_unittests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Xianzhu
8 years, 3 months ago (2012-09-21 05:34:08 UTC) #1
sky
Can you upload the patch you landed, then the fix so we can easily see ...
8 years, 3 months ago (2012-09-21 16:14:00 UTC) #2
Xianzhu
On 2012/09/21 16:14:00, sky wrote: > Can you upload the patch you landed, then the ...
8 years, 3 months ago (2012-09-24 17:44:48 UTC) #3
sky
8 years, 3 months ago (2012-09-24 20:55:55 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698