Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 10962022: Android device status: create out dir if needed (Closed)

Created:
8 years, 3 months ago by Isaac (away)
Modified:
8 years, 3 months ago
Reviewers:
bulach
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Android device status: create out dir if needed - I recently changed device status to run before gyp This exposed a dependence on the out directory existing and broke new android testers. TEST=Ran device status with --out-dir pointing to non-existent dir. R=bulach@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M build/android/device_status_check.py View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Isaac (away)
8 years, 3 months ago (2012-09-21 01:02:38 UTC) #1
bulach
8 years, 3 months ago (2012-09-21 11:18:15 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698