Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1096183003: bluetooth: Refactor bluetooth_adapter.cc for C++ style: dcl/dfn ordering. (Closed)

Created:
5 years, 8 months ago by scheib
Modified:
5 years, 8 months ago
Reviewers:
armansito
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bta-style-typedefs-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Refactor bluetooth_adapter.cc for C++ style: dcl/dfn ordering. Refactoring in preparation of additional code changes to BluetoothAdapter before implementing an Android version. No code line changes, only moved definition blocks to match declaration order: https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Declaration_Order BUG=471536 Committed: https://crrev.com/546156371290ca98828b0edfbb3125840da0969e Cr-Commit-Position: refs/heads/master@{#326168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -54 lines) Patch
M device/bluetooth/bluetooth_adapter.cc View 4 chunks +53 lines, -54 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
scheib
5 years, 8 months ago (2015-04-21 00:29:28 UTC) #2
armansito
This kind of refactors really pollute the history and harder to find things in a ...
5 years, 8 months ago (2015-04-21 23:09:02 UTC) #3
scheib
On 2015/04/21 23:09:02, armansito wrote: > This kind of refactors really pollute the history and ...
5 years, 8 months ago (2015-04-21 23:16:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096183003/1
5 years, 8 months ago (2015-04-21 23:19:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-21 23:24:58 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 23:25:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/546156371290ca98828b0edfbb3125840da0969e
Cr-Commit-Position: refs/heads/master@{#326168}

Powered by Google App Engine
This is Rietveld 408576698