Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4309)

Unified Diff: chrome/common/extensions/api/search_engines_private.idl

Issue 1096143003: Add chrome.searchEnginesPrivate API and Search Settings page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/search_engines_private.idl
diff --git a/chrome/common/extensions/api/search_engines_private.idl b/chrome/common/extensions/api/search_engines_private.idl
new file mode 100644
index 0000000000000000000000000000000000000000..1f79ae5667439144eb68ac0fc3a575cedf92a7ed
--- /dev/null
+++ b/chrome/common/extensions/api/search_engines_private.idl
@@ -0,0 +1,34 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Use the <code>chrome.searchEnginesPrivate</code> API to get or set
+// preferences from the settings UI.
+namespace searchEnginesPrivate {
not at google - send to devlin 2015/04/22 19:32:59 How will this interact with the search engine over
Oren Blasberg 2015/04/22 22:36:11 Hmm, where is that API located? I can't find it an
not at google - send to devlin 2015/04/22 22:43:51 It's called "chrome_settings_overrides", implement
Oren Blasberg 2015/04/22 22:59:19 Ah, I see. Yes, we will likely iterate on the sear
+
+ dictionary SearchEngine {
+ // The unique ID of the engine in the list.
stevenjb 2015/04/22 19:46:30 'The unique identifier for the search engine.'
Oren Blasberg 2015/04/23 17:05:08 Done.
+ DOMString guid;
+
+ // The name of the engine.
+ DOMString name;
+
+ // Whether the engine is default.
stevenjb 2015/04/22 19:46:30 'Whether the engine is the default search engine'
Oren Blasberg 2015/04/23 17:05:08 Done.
+ boolean isDefault;
+ };
+
+ callback SearchEnginesCallback = void (SearchEngine[] engines);
+
+ interface Functions {
+ // Gets an array of all the default (not custom) search engines.
+ static void getDefaultSearchEngines(SearchEnginesCallback callback);
+
+ // Sets the default search engine.
+ static void setDefaultSearchEngine(DOMString guid);
stevenjb 2015/04/22 19:46:30 See discussion in API doc
Oren Blasberg 2015/04/23 17:05:08 Done.
+ };
+
+ interface Events {
+ // Fires when the list of engines or the default engine changes.
+ static void onSearchEnginesChanged(SearchEngine[] engines);
stevenjb 2015/04/22 19:46:30 See discussion in API doc
Oren Blasberg 2015/04/23 17:05:08 Done.
+ };
+};

Powered by Google App Engine
This is Rietveld 408576698