Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1096133003: Adding extensions ids to Chrome Feedback whitelist. (Closed)

Created:
5 years, 8 months ago by bmalcolm
Modified:
5 years, 8 months ago
Reviewers:
rkc
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding extensions ids to Chrome Feedback whitelist. BUG=478929 Committed: https://crrev.com/7cd6bb4c5594d96174aaec234b9870077071509c Cr-Commit-Position: refs/heads/master@{#326685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/feedback/js/event_handler.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
rkc
lgtm
5 years, 8 months ago (2015-04-23 17:42:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096133003/1
5 years, 8 months ago (2015-04-23 20:54:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/30543)
5 years, 8 months ago (2015-04-23 21:02:01 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096133003/1
5 years, 8 months ago (2015-04-23 22:04:43 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-23 22:53:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096133003/1
5 years, 8 months ago (2015-04-23 22:58:01 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 22:59:05 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 22:59:49 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7cd6bb4c5594d96174aaec234b9870077071509c
Cr-Commit-Position: refs/heads/master@{#326685}

Powered by Google App Engine
This is Rietveld 408576698