Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: patches/nss-libpkix-leak.patch

Issue 10961060: Update NSS to NSS 3.14 Beta 1. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/nss/
Patch Set: Add the NSS snapshot timestamp to README.chromium and nss-checkout.sh Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « patches/nss-der-encode-time-choice.patch ('k') | patches/nss-static.patch » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: patches/nss-libpkix-leak.patch
===================================================================
--- patches/nss-libpkix-leak.patch (revision 158129)
+++ patches/nss-libpkix-leak.patch (working copy)
@@ -1,35 +0,0 @@
-diff --git a/mozilla/security/nss/lib/certhigh/certvfypkix.c b/mozilla/security/nss/lib/certhigh/certvfypkix.c
-index 33790df..375a370 100644
---- a/mozilla/security/nss/lib/certhigh/certvfypkix.c
-+++ b/mozilla/security/nss/lib/certhigh/certvfypkix.c
-@@ -1457,9 +1457,10 @@ PKIX_List *cert_PKIXMakeOIDList(const SECOidTag *oids, int oidCount, void *plCon
- error = PKIX_List_AppendItem(policyList,
- (PKIX_PL_Object *)policyOID, plContext);
- if (error != NULL) {
-- PKIX_PL_Object_DecRef((PKIX_PL_Object *)policyOID, plContext);
- goto cleanup;
- }
-+ PKIX_PL_Object_DecRef((PKIX_PL_Object *)policyOID, plContext);
-+ policyOID = NULL;
- }
-
- error = PKIX_List_SetImmutable(policyList, plContext);
-diff --git a/mozilla/security/nss/lib/libpkix/pkix_pl_nss/system/pkix_pl_oid.c b/mozilla/security/nss/lib/libpkix/pkix_pl_nss/system/pkix_pl_oid.c
-index 69c8a9f..8a68450 100755
---- a/mozilla/security/nss/lib/libpkix/pkix_pl_nss/system/pkix_pl_oid.c
-+++ b/mozilla/security/nss/lib/libpkix/pkix_pl_nss/system/pkix_pl_oid.c
-@@ -328,10 +328,11 @@ PKIX_PL_OID_CreateBySECItem(
- plContext),
- PKIX_COULDNOTCREATEOBJECT);
- rv = SECITEM_CopyItem(NULL, &oid->derOid, derOid);
-- if (rv != SECFailure) {
-- *pOID = oid;
-- oid = NULL;
-+ if (rv != SECSuccess) {
-+ PKIX_ERROR(PKIX_OUTOFMEMORY);
- }
-+ *pOID = oid;
-+ oid = NULL;
-
- cleanup:
- PKIX_DECREF(oid);
« no previous file with comments | « patches/nss-der-encode-time-choice.patch ('k') | patches/nss-static.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698