Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Side by Side Diff: patches/nss-libpkix-leak.patch

Issue 10961060: Update NSS to NSS 3.14 Beta 1. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/nss/
Patch Set: Add the NSS snapshot timestamp to README.chromium and nss-checkout.sh Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « patches/nss-der-encode-time-choice.patch ('k') | patches/nss-static.patch » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 diff --git a/mozilla/security/nss/lib/certhigh/certvfypkix.c b/mozilla/security/ nss/lib/certhigh/certvfypkix.c
2 index 33790df..375a370 100644
3 --- a/mozilla/security/nss/lib/certhigh/certvfypkix.c
4 +++ b/mozilla/security/nss/lib/certhigh/certvfypkix.c
5 @@ -1457,9 +1457,10 @@ PKIX_List *cert_PKIXMakeOIDList(const SECOidTag *oids, in t oidCount, void *plCon
6 error = PKIX_List_AppendItem(policyList,
7 (PKIX_PL_Object *)policyOID, plContext);
8 if (error != NULL) {
9 - PKIX_PL_Object_DecRef((PKIX_PL_Object *)policyOID, plContext);
10 goto cleanup;
11 }
12 + PKIX_PL_Object_DecRef((PKIX_PL_Object *)policyOID, plContext);
13 + policyOID = NULL;
14 }
15
16 error = PKIX_List_SetImmutable(policyList, plContext);
17 diff --git a/mozilla/security/nss/lib/libpkix/pkix_pl_nss/system/pkix_pl_oid.c b /mozilla/security/nss/lib/libpkix/pkix_pl_nss/system/pkix_pl_oid.c
18 index 69c8a9f..8a68450 100755
19 --- a/mozilla/security/nss/lib/libpkix/pkix_pl_nss/system/pkix_pl_oid.c
20 +++ b/mozilla/security/nss/lib/libpkix/pkix_pl_nss/system/pkix_pl_oid.c
21 @@ -328,10 +328,11 @@ PKIX_PL_OID_CreateBySECItem(
22 plContext),
23 PKIX_COULDNOTCREATEOBJECT);
24 rv = SECITEM_CopyItem(NULL, &oid->derOid, derOid);
25 - if (rv != SECFailure) {
26 - *pOID = oid;
27 - oid = NULL;
28 + if (rv != SECSuccess) {
29 + PKIX_ERROR(PKIX_OUTOFMEMORY);
30 }
31 + *pOID = oid;
32 + oid = NULL;
33
34 cleanup:
35 PKIX_DECREF(oid);
OLDNEW
« no previous file with comments | « patches/nss-der-encode-time-choice.patch ('k') | patches/nss-static.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698