Issue 1096063003: Regularize informative messages in Android font parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1096063003: Regularize informative messages in Android font parser. (Closed)

Created:
5 years, 8 months ago by bungeman-skia

Modified:
5 years, 8 months ago

Reviewers:
tomhudson

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Regularize informative messages in Android font parser. The Android font parser prints a number of helpful messages when something seems amiss in the configuration file. Give all of these messages a common and more informative format. Committed: https://skia.googlesource.com/skia/+/f61475e95d9bb38f741f9e51221c086250b9ad72

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -41 lines)			Patch
	M	src/ports/SkFontConfigParser_android.cpp	View		18 chunks	+57 lines, -41 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

bungeman-skia

Another round of regularizing things in the parser code.

5 years, 8 months ago (2015-04-20 17:38:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096063003/1

5 years, 8 months ago (2015-04-20 18:09:33 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-20 18:16:53 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f61475e95d9bb38f741f9e51221c086250b9ad72

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages