runtime/vm/stub_code_arm64.cc - Issue 1096063002: Fix array allocation overflow check on arm/arm64/mips.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_arm64.cc

Issue 1096063002: Fix array allocation overflow check on arm/arm64/mips. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_arm64.cc

===================================================================

--- runtime/vm/stub_code_arm64.cc (revision 45353)

+++ runtime/vm/stub_code_arm64.cc (working copy)

@@ -659,8 +659,10 @@

__ add(R3, R3, Operand(R2, LSL, 2)); // R2 is Smi.

ASSERT(kSmiTagShift == 1);

__ andi(R3, R3, Immediate(~(kObjectAlignment - 1)));

+ // R0: potential new object start.

+ // R3: object size in bytes.

__ adds(R7, R3, Operand(R0));

- __ b(&slow_case, VS);

+ __ b(&slow_case, CS); // Branch if unsigned overflow.

// Check if the allocation fits into the remaining space.

// R0: potential new object start.

« no previous file with comments | « runtime/vm/stub_code_arm.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »