Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 1096053002: Avoid having untyped slots for objects embedded into code. (Closed)

Created:
5 years, 8 months ago by Igor Sheludko
Modified:
5 years, 8 months ago
Reviewers:
rmcilroy
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid having untyped slots for objects embedded into code because it breaks slots filtering. BUG=chromium:478747, chromium:478811 LOG=N Committed: https://crrev.com/7ad9980d995b0381046ee8677861491ef6d234ed Cr-Commit-Position: refs/heads/master@{#27950}

Patch Set 1 : #

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M src/heap/mark-compact.cc View 1 1 chunk +3 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Jakob Kummerow
I'm deferring to Ross here, who judging by https://codereview.chromium.org/179813005 is more familiar with this code ...
5 years, 8 months ago (2015-04-20 17:19:42 UTC) #2
rmcilroy
On 2015/04/20 17:19:42, Jakob wrote: > I'm deferring to Ross here, who judging by > ...
5 years, 8 months ago (2015-04-20 17:48:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096053002/40001
5 years, 8 months ago (2015-04-20 23:43:54 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 8 months ago (2015-04-20 23:45:21 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 23:45:38 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ad9980d995b0381046ee8677861491ef6d234ed
Cr-Commit-Position: refs/heads/master@{#27950}

Powered by Google App Engine
This is Rietveld 408576698