Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(43)

Issue 10960021: Merge 128972 - [Chromium] Fix crash in WebFrameImpl::loadHistoryItem (Closed)

Created:
8 years, 5 months ago by kerz_chromium
Modified:
8 years, 5 months ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Visibility:
Public.

Description

Merge 128972 - [Chromium] Fix crash in WebFrameImpl::loadHistoryItem https://bugs.webkit.org/show_bug.cgi?id=96352 Reviewed by Adam Barth. We have some crash reports with the following stack: - HistoryItem::shouldDoSameDocumentNavigationTo. - WebFrameImpl::loadHistoryItem ... We don't have reproducible steps, and not sure what's the root cause. Anyway we should check nullness of currentItem because HistoryController::m_currentItem can be 0. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadHistoryItem): Check nullness of currentItem. TBR=tkent@chromium.org Committed: https://trac.webkit.org/changeset/129177

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/WebKit/chromium/src/WebFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
kerz_chromium
8 years, 5 months ago (2012-09-20 23:30:28 UTC) #1
tkent
8 years, 5 months ago (2012-09-21 00:46:44 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698