Issue 10960021: Merge 128972 - [Chromium] Fix crash in WebFrameImpl::loadHistoryItem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10960021: Merge 128972 - [Chromium] Fix crash in WebFrameImpl::loadHistoryItem (Closed)

Created:
8 years, 3 months ago by kerz_chromium

Modified:
8 years, 3 months ago

Reviewers:
tkent

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/

Visibility:
Public.

More Reviews

Description

Merge 128972 - [Chromium] Fix crash in WebFrameImpl::loadHistoryItem https://bugs.webkit.org/show_bug.cgi?id=96352 Reviewed by Adam Barth. We have some crash reports with the following stack: - HistoryItem::shouldDoSameDocumentNavigationTo. - WebFrameImpl::loadHistoryItem ... We don't have reproducible steps, and not sure what's the root cause. Anyway we should check nullness of currentItem because HistoryController::m_currentItem can be 0. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadHistoryItem): Check nullness of currentItem. TBR=tkent@chromium.org Committed: https://trac.webkit.org/changeset/129177

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/WebKit/chromium/src/WebFrameImpl.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages