Implement range analysis for smi values.

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 1460 matching lines @@
     return summary;
   }
 }
 
 
 void BinarySmiOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   Register left = locs()->in(0).reg();
   Register result = locs()->out().reg();
   ASSERT(left == result);
   Label* deopt = NULL;
-  switch (op_kind()) {
-    case Token::kBIT_AND:
-    case Token::kBIT_OR:
-    case Token::kBIT_XOR:
-      // Can't deoptimize. Arguments are already checked for smi.
-      break;
-    default:
+  if (CanDeoptimize()) {
       deopt  = compiler->AddDeoptStub(instance_call()->deopt_id(),
                                       kDeoptBinarySmiOp);
   }
 
   if (locs()->in(1).IsConstant()) {
     const Object& constant = locs()->in(1).constant();
     ASSERT(constant.IsSmi());
     const int32_t imm =
         reinterpret_cast<int32_t>(constant.raw());
     switch (op_kind()) {
       case Token::kADD:
         __ addl(left, Immediate(imm));
-        __ j(OVERFLOW, deopt);
+        if (deopt != NULL) __ j(OVERFLOW, deopt);
         break;
       case Token::kSUB: {
         __ subl(left, Immediate(imm));
-        __ j(OVERFLOW, deopt);
+        if (deopt != NULL) __ j(OVERFLOW, deopt);
         break;
       }
       case Token::kMUL: {
         // Keep left value tagged and untag right value.
         const intptr_t value = Smi::Cast(constant).Value();
         __ imull(left, Immediate(value));
-        __ j(OVERFLOW, deopt);
+        if (deopt != NULL) __ j(OVERFLOW, deopt);
         break;
       }
       case Token::kBIT_AND: {
         // No overflow check.
         __ andl(left, Immediate(imm));
         break;
       }
       case Token::kBIT_OR: {
         // No overflow check.
         __ orl(left, Immediate(imm));
@@ skipping 30 matching lines @@
         UNREACHABLE();
         break;
     }
     return;
   }
 
   Register right = locs()->in(1).reg();
   switch (op_kind()) {
     case Token::kADD: {
       __ addl(left, right);
-      __ j(OVERFLOW, deopt);
+      if (deopt != NULL) __ j(OVERFLOW, deopt);
       break;
     }
     case Token::kSUB: {
       __ subl(left, right);
-      __ j(OVERFLOW, deopt);
+      if (deopt != NULL) __ j(OVERFLOW, deopt);
       break;
     }
     case Token::kMUL: {
       __ SmiUntag(left);
       __ imull(left, right);
       __ j(OVERFLOW, deopt);

[Florian Schneider, 2012/09/21 08:56:44]

if (deopt != NULL) __ j(OVERFLOW, deopt);

[Vyacheslav Egorov (Google), 2012/09/21 20:08:07]

Done.

       break;
     }
     case Token::kBIT_AND: {
       // No overflow check.
       __ andl(left, right);
       break;
     }
     case Token::kBIT_OR: {
       // No overflow check.
       __ orl(left, right);
@@ skipping 641 matching lines @@
     __ j(ABOVE_EQUAL, deopt);
   }
 }
 
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64